Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Revert "ble: Remove CONFIG_BT_BUF_ACL_RX_COUNT"" #671

Conversation

PavelVPV
Copy link
Contributor

@PavelVPV PavelVPV commented Jan 7, 2025

This reverts commit 7767d43.

CI parameters

Github_actions:
  #(branch, hash, pull/XXX/head)
  NRF_revision: main

  # Do not change after creating PR
  Create_NRF_PR: false
Jenkins:
  test-sdk-sidewalk: master

Description

JIRA ticket:

Self review

  • There is no commented code.
  • There are no TODO/FIXME comments without associated issue ticket.
  • Commits are properly organized.
  • Change has been tested.
  • Tests were updated (if applicable).

@github-actions github-actions bot added the source PR changing src files label Jan 7, 2025
@PavelVPV
Copy link
Contributor Author

PavelVPV commented Jan 7, 2025

@ktaborowski , nrfconnect/sdk-nrf#19412 is merged now.

Copy link

github-actions bot commented Jan 7, 2025

Sample diff used total
nrf52840dk/nrf52840:sample.sidewalk.demo RAM 4 B 123.65 KB 0 B
ROM 64 B 478.99 KB 0 B
nrf52840dk/nrf52840:sample.sidewalk.demo.ble_only RAM 4 B 108.3 KB 0 B
ROM 64 B 396.52 KB 0 B
nrf52840dk/nrf52840:sample.sidewalk.dut RAM 4 B 147.29 KB 0 B
ROM 56 B 544.95 KB 0 B
nrf52840dk/nrf52840:sample.sidewalk.dut.ble_only RAM 4 B 131.88 KB 0 B
ROM 56 B 461.85 KB 0 B
nrf5340dk/nrf5340/cpuapp:sample.sidewalk.demo RAM 292 B 115.16 KB 0 B
ROM 84 B 401.82 KB 0 B
nrf5340dk/nrf5340/cpuapp:sample.sidewalk.demo.ble_only RAM 292 B 99.96 KB 0 B
ROM 84 B 318.22 KB 0 B
nrf5340dk/nrf5340/cpuapp:sample.sidewalk.dut RAM 292 B 138.92 KB 0 B
ROM 76 B 468.52 KB 0 B
nrf5340dk/nrf5340/cpuapp:sample.sidewalk.dut.ble_only RAM 292 B 123.68 KB 0 B
ROM 76 B 384.45 KB 0 B
nrf54l15dk/nrf54l10/cpuapp:sample.sidewalk.demo RAM 4 B 121.57 KB 0 B
ROM 60 B 457.8 KB 0 B
nrf54l15dk/nrf54l10/cpuapp:sample.sidewalk.demo.ble_only RAM 4 B 106.53 KB 0 B
ROM 60 B 380.04 KB 0 B
nrf54l15dk/nrf54l10/cpuapp:sample.sidewalk.dut RAM 4 B 145.32 KB 0 B
ROM 56 B 524.25 KB 0 B
nrf54l15dk/nrf54l10/cpuapp:sample.sidewalk.dut.ble_only RAM 4 B 130.22 KB 0 B
ROM 56 B 445.97 KB 0 B
nrf54l15dk/nrf54l15/cpuapp:sample.sidewalk.demo RAM 4 B 121.57 KB 0 B
ROM 64 B 457.83 KB 0 B
nrf54l15dk/nrf54l15/cpuapp:sample.sidewalk.demo.ble_only RAM 4 B 106.53 KB 0 B
ROM 64 B 380.07 KB 0 B
nrf54l15dk/nrf54l15/cpuapp:sample.sidewalk.dut RAM 4 B 145.32 KB 0 B
ROM 52 B 524.29 KB 0 B
nrf54l15dk/nrf54l15/cpuapp:sample.sidewalk.dut.ble_only RAM 4 B 130.22 KB 0 B
ROM 52 B 446 KB 0 B
nrf54l15dk/nrf54l15/cpuapp/ns:sample.sidewalk.demo RAM 4 B 120.79 KB 0 B
ROM 60 B 406.49 KB 0 B
nrf54l15dk/nrf54l15/cpuapp/ns:sample.sidewalk.demo.ble_only RAM 4 B 105.75 KB 0 B
ROM 60 B 328.73 KB 0 B
nrf54l15dk/nrf54l15/cpuapp/ns:sample.sidewalk.dut RAM 4 B 144.54 KB 0 B
ROM 56 B 473.18 KB 0 B
nrf54l15dk/nrf54l15/cpuapp/ns:sample.sidewalk.dut.ble_only RAM 4 B 129.44 KB 0 B
ROM 56 B 394.89 KB 0 B
nrf52840dk/nrf52840:sample.sidewalk.dut.no_secure RAM 4 B 147.26 KB 0 B
ROM 56 B 536.42 KB 0 B
nrf52840dk/nrf52840:sample.sidewalk.hello RAM 4 B 124.87 KB 0 B
ROM 60 B 494.29 KB 0 B
nrf52840dk/nrf52840:sample.sidewalk.hello.ble_only RAM 4 B 98.13 KB 0 B
ROM 64 B 394.84 KB 0 B
nrf5340dk/nrf5340/cpuapp:sample.sidewalk.dut.no_secure RAM 292 B 138.91 KB 0 B
ROM 76 B 461.08 KB 0 B
nrf5340dk/nrf5340/cpuapp:sample.sidewalk.hello RAM 292 B 116.65 KB 0 B
ROM 84 B 417.38 KB 0 B
nrf5340dk/nrf5340/cpuapp:sample.sidewalk.hello.ble_only RAM 292 B 90.05 KB 0 B
ROM 84 B 316.78 KB 0 B
nrf54l15dk/nrf54l10/cpuapp:sample.sidewalk.dut.no_secure RAM 4 B 145.31 KB 0 B
ROM 56 B 516.57 KB 0 B
nrf54l15dk/nrf54l10/cpuapp:sample.sidewalk.hello RAM 4 B 123.02 KB 0 B
ROM 64 B 473.08 KB 0 B
nrf54l15dk/nrf54l10/cpuapp:sample.sidewalk.hello.ble_only RAM 4 B 96.57 KB 0 B
ROM 60 B 378.36 KB 0 B
nrf54l15dk/nrf54l15/cpuapp:sample.sidewalk.dut.no_secure RAM 4 B 145.31 KB 0 B
ROM 52 B 516.6 KB 0 B
nrf54l15dk/nrf54l15/cpuapp:sample.sidewalk.hello RAM 4 B 123.02 KB 0 B
ROM 60 B 473.12 KB 0 B
nrf54l15dk/nrf54l15/cpuapp:sample.sidewalk.hello.ble_only RAM 4 B 96.57 KB 0 B
ROM 64 B 378.39 KB 0 B
nrf54l15dk/nrf54l15/cpuapp/ns:sample.sidewalk.dut.no_secure RAM 4 B 144.54 KB 0 B
ROM 56 B 470.48 KB 0 B
nrf54l15dk/nrf54l15/cpuapp/ns:sample.sidewalk.hello RAM 4 B 122.24 KB 0 B
ROM 64 B 421.78 KB 0 B
nrf54l15dk/nrf54l15/cpuapp/ns:sample.sidewalk.hello.ble_only RAM 4 B 95.79 KB 0 B
ROM 60 B 327.05 KB 0 B
nrf52840dk/nrf52840:sample.sidewalk.hello.ble_only.release RAM 4 B 93.32 KB 0 B
ROM 52 B 325.44 KB 0 B
nrf52840dk/nrf52840:sample.sidewalk.hello.release RAM 4 B 108.67 KB 0 B
ROM 52 B 404.41 KB 0 B
nrf5340dk/nrf5340/cpuapp:sample.sidewalk.hello.ble_only.release RAM 292 B 85.4 KB 0 B
ROM 96 B 245.11 KB 0 B
nrf5340dk/nrf5340/cpuapp:sample.sidewalk.hello.release RAM 292 B 100.6 KB 0 B
ROM 96 B 324.87 KB 0 B
nrf54l15dk/nrf54l10/cpuapp:sample.sidewalk.hello.ble_only.release RAM 4 B 91.94 KB 0 B
ROM 52 B 306.91 KB 0 B
nrf54l15dk/nrf54l10/cpuapp:sample.sidewalk.hello.release RAM 4 B 107 KB 0 B
ROM 52 B 382.79 KB 0 B
nrf54l15dk/nrf54l15/cpuapp:sample.sidewalk.hello.ble_only.release RAM 4 B 91.94 KB 0 B
ROM 52 B 306.94 KB 0 B
nrf54l15dk/nrf54l15/cpuapp:sample.sidewalk.hello.release RAM 4 B 107 KB 0 B
ROM 52 B 382.82 KB 0 B
nrf54l15dk/nrf54l15/cpuapp/ns:sample.sidewalk.hello.ble_only.release RAM 4 B 91.16 KB 0 B
ROM 52 B 256.54 KB 0 B
nrf54l15dk/nrf54l15/cpuapp/ns:sample.sidewalk.hello.release RAM 4 B 106.22 KB 0 B
ROM 52 B 332.4 KB 0 B

This reverts commit 7767d43.

Signed-off-by: Pavel Vasilyev <[email protected]>
@PavelVPV PavelVPV force-pushed the revert_revert_config_bt_buf_acl_rx_count branch from c7950b4 to 5e8d29b Compare January 7, 2025 13:34
@RobertGalatNordic RobertGalatNordic self-requested a review January 7, 2025 13:44
@RobertGalatNordic RobertGalatNordic merged commit fa7bc0e into nrfconnect:main Jan 7, 2025
47 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
source PR changing src files
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants