-
Notifications
You must be signed in to change notification settings - Fork 624
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Wi-Fi upmerge for 2.8.0 #2142
Merged
Merged
Wi-Fi upmerge for 2.8.0 #2142
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
krish2718
force-pushed
the
wifi_upmerge
branch
from
October 21, 2024 19:10
825271d
to
dedbedd
Compare
NordicBuilder
requested review from
hubertmis,
jaz1-nordic,
jfischer-no,
jukkar,
kl-cruz,
magp-nordic,
masz-nordic,
nika-nordic,
nordic-krch,
rajb9,
rlubos,
sachinthegreen,
srkanordic and
udaynordic
October 21, 2024 19:10
The following west manifest projects have been modified in this Pull Request:
Note: This message is automatically posted and updated by the Manifest GitHub Action. |
krish2718
force-pushed
the
wifi_upmerge
branch
from
October 21, 2024 19:31
dedbedd
to
764fb58
Compare
If CONFIG_WIFI_NM_WPA_SUPPLICANT_CRYPTO_NONE is enabled, there are lot of missing functions reported during linking. Add missing C files to the compilation to fix this. Signed-off-by: Jukka Rissanen <[email protected]> (cherry picked from commit 980a352)
Both the supplicant_set_btwt() and supplicant_ap_bandwidth() are not found in Zephyr sources so remove them. Signed-off-by: Jukka Rissanen <[email protected]> (cherry picked from commit 6ac4e9c)
The "enum wpa_msg_type" was not found by default so add needed include files to get the definitions. modules/hostap/src/supp_main.h:61:57: warning: ‘enum wpa_msg_type’ declared inside parameter list will not be visible outside of this definition or declaration 61 | void wpa_supplicant_msg_send(void *ctx, int level, enum wpa_msg_type type, const char *txt, Signed-off-by: Jukka Rissanen <[email protected]> (cherry picked from commit c9b8365)
Even if the enum contains the same values, the values might change if the wpa_supplicant sources change or Zephyr values change. In order to avoid weird errors later and prevent the following warning, add a conversion functions for the enums. modules/hostap/src/supp_api.c:1172:23: warning: implicit conversion from enumeration type 'enum mfp_options' to different enumeration type 'enum wifi_mfp_options' [-Wenum-conversion] status->mfp = ssid->ieee80211w; /* Same mapping */ modules/hostap/src/supp_api.c:1190:30: warning: implicit conversion from enumeration type 'enum wpas_mode' to different enumeration type 'enum wifi_iface_mode' [-Wenum-conversion] status->iface_mode = ssid->mode; Signed-off-by: Jukka Rissanen <[email protected]> (cherry picked from commit ec21dab)
…mbinations Try to compile test wifi with various configuration combinations. This is trying to catch simple compilation issues in the PRs. Signed-off-by: Jukka Rissanen <[email protected]> (cherry picked from commit 3f8828d)
This is related to work on #79973 which creates build tests for hostap with different configurations. Signed-off-by: Jukka Rissanen <[email protected]> (cherry picked from commit 3cf8b09)
…imeout WPA control interface timeout is hardcoded to 10s, add a configuration option to remove the hardcode, this is needed sometimes as a workaround e.g., crypto taking too long to complete the request. Work around for #79834, increase the default from 10 to 15s, in positive case this will have no impact. Signed-off-by: Chaitanya Tata <[email protected]> (cherry picked from commit 78f5821)
Execute certificate headers creation rules only if Wi-Fi Enterprise mode is enabled. Upstream PR: zephyrproject-rtos/zephyr#80212 Signed-off-by: Ravi Dondaputi <[email protected]>
Few build errors due to bugs in previous commits. Signed-off-by: Chaitanya Tata <[email protected]> (cherry picked from commit f6b60bd)
The defines should explicitly be passed to nordic HAL as they dont' use the CONFIG_ prefix. Signed-off-by: Chaitanya Tata <[email protected]> (cherry picked from commit 3098c48)
Missed adding CONFIG_ to the configuration option. Signed-off-by: Chaitanya Tata <[email protected]> (cherry picked from commit f840f66)
When debug is disabled, seeing a build error for unused variable. Upstream PR: zephyrproject-rtos/zephyr#80315 Signed-off-by: Chaitanya Tata <[email protected]>
krish2718
force-pushed
the
wifi_upmerge
branch
2 times, most recently
from
October 24, 2024 17:05
1c70ed9
to
8a44627
Compare
Support Wi-Fi enterprise mode with NRF_SECURITY. Signed-off-by: Ravi Dondaputi <[email protected]>
Enable wifi sample to connect in EAP-TLS mode. Create sample certificates. Signed-off-by: Ravi Dondaputi <[email protected]>
This brings in PSA Kconfig and CMakelist.txt changes to NCS. Currently, it contains known PSA configurations and source files that are needed or will be needed in the future. WPA3 and Enterprise is currently disabled with this setting. Signed-off-by: Vivekananda Uppunda <[email protected]> Signed-off-by: Chaitanya Tata <[email protected]>
Make sure Wi-Fi driver is enabled when sysbuild is used. For shields we cannot automate this, as sysbuild doesn't recognize shields, so, Wi-Fi has to be explicitly enabled, this is done for twister. Signed-off-by: Chaitanya Tata <[email protected]>
Build throw macro redefined error as it's already defined by the nRF security module. Signed-off-by: Chaitanya Tata <[email protected]>
The file has been removed upstream, but as upstream doesn't have NS support, this need to be fixed explicitly. Upstream PR: zephyrproject-rtos/zephyr#79606 Signed-off-by: Chaitanya Tata <[email protected]>
NS builds need to use PSA for entropy same as 54L. Signed-off-by: Chaitanya Tata <[email protected]>
Upstream certificates are RSA3K + Suite-B, they are not support yet on nRF boards, so, generate a new certificate for both phase1 and phase2 and use them. Signed-off-by: Chaitanya Tata <[email protected]> Signed-off-by: Ravi Dondaputi <[email protected]>
For 54H Legacy mode is broken, so, enable PSA at the cost of supporting WPA2 only. Signed-off-by: Chaitanya Tata <[email protected]>
krish2718
force-pushed
the
wifi_upmerge
branch
from
October 24, 2024 20:08
8a44627
to
d8ba4d2
Compare
rlubos
force-pushed
the
wifi_upmerge
branch
2 times, most recently
from
October 25, 2024 11:38
999f721
to
d8ba4d2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This cherry-picks all Wi-Fi fixes (Boards, drivers and hostap) for 2.8.0 release.