Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[nrf fromlist] Fix SPIM120 handling when power management is enabled #2356

Merged
merged 11 commits into from
Dec 13, 2024
Merged

[nrf fromlist] Fix SPIM120 handling when power management is enabled #2356

merged 11 commits into from
Dec 13, 2024

Conversation

nika-nordic
Copy link
Contributor

@nika-nordic nika-nordic added this to the ncs-2.9.0-nRF54H20 milestone Dec 10, 2024
@NordicBuilder NordicBuilder mentioned this pull request Dec 10, 2024
Closed
@nika-nordic nika-nordic requested a review from nordicjm December 10, 2024 14:30
@nika-nordic
Copy link
Contributor Author

@nordicjm this commit: 78487f2 is built on top of already merged fromlist sdk-zephyr PR: #1882 . As upstream variant was still not merged: zephyrproject-rtos/zephyr#75715 and there are opened request changes, commits-tags won't pass.

Is there any way forward you would suggest, provided that zephyrproject-rtos/zephyr#75715 won't be merged anytime soon probably?

@nordicjm
Copy link
Contributor

@nordicjm this commit: 78487f2 is built on top of already merged fromlist sdk-zephyr PR: #1882 . As upstream variant was still not merged: zephyrproject-rtos/zephyr#75715 and there are opened request changes, commits-tags won't pass.

Is there any way forward you would suggest, provided that zephyrproject-rtos/zephyr#75715 won't be merged anytime soon probably?

No other way than to address the requested changes then update fromlist to pull those in

nordic-krch and others added 11 commits December 13, 2024 12:51
@nordic-krch @nika-nordic
[nrf fromlist] modules: hal_nordic: nrfs: Optimize communication
ce331ea 
It is not needed to use always the system work queue to send a
message over IPC. In thread context IPC service can be called
directly. It speeds up the communication and allows to use nrfs
from the system work queue. Legacy approach could easily lead
to the deadlock if user would call nrfs from work queue and
pend on semaphore until response is received.

Upstream PR #: 81455

Signed-off-by: Krzysztof Chruściński <[email protected]>
@nika-nordic
Revert "[nrf fromlist] tests: drivers: spi: nordic: add device PM run…
c09639b 
…time"

This reverts commit 2124691.

Signed-off-by: Nikodem Kastelik <[email protected]>
@nika-nordic
Revert "[nrf fromlist] drivers: spi: nrfx_spim: Add support for devic…
2e60f26 
…e runtime PM"

This reverts commit 22632c9.

Signed-off-by: Nikodem Kastelik <[email protected]>
@nordic-krch @nika-nordic
[nrf fromtree] tests: drivers: spi: spi_controller_peripheral: Add nr…
9ea6a7b 
…f54h20dk cpuppr

Rework existing nrf54h20dk overlays to allow adding of
nrf54h20dk//cpuppr target.

Signed-off-by: Krzysztof Chruściński <[email protected]>
(cherry picked from commit 949566f)
@Ayush1325 @nika-nordic
[nrf fromtree] samples: net: sockets: echo_server: Add 802154-subg test
1999638 
- Using beagleconnect freedom for testing subg overlay

Signed-off-by: Ayush Singh <[email protected]>
(cherry picked from commit 40d8926)
@butok @nika-nordic
[nrf fromtree] yaml: use EXTRA_CONF_FILE in .yaml files
20a41d8 
Use EXTRA_CONF_FILE in sample yaml files,
that replaced deprecated OVERLAY_CONFIG
since the Zephyr v3.4 release.

Signed-off-by: Andrej Butok <[email protected]>
(cherry picked from commit e53eec0)
@tunguyen4585 @nika-nordic
[nrf fromtree] tests: drivers: spi: enable test spi_loopback
7a02471 
enable test spi_loopback for dspi feature on s32z27x
devices

Signed-off-by: Tu Nguyen Van <[email protected]>
(cherry picked from commit 55bcc4a)
@dimitrije-lilic @nika-nordic
[nrf fromtree] tests: drivers: spi: spi_loopback: Support RTIO tests …
095b656 
…for APARD32690

Add overlay for APARD32690 board and add a new test case to
test RTIO functionalities of SPI MAX32 driver.

Signed-off-by: Dimitrije Lilic <[email protected]>
(cherry picked from commit 2507752)
@nordic-krch @nika-nordic
[nrf fromtree] tests: drivers: spi: spi_loopback: Add nrf54h20dk cpurad
29cb8c3 
Add overlay for nrf54h20dk cpurad.

Signed-off-by: Krzysztof Chruściński <[email protected]>
(cherry picked from commit 20c34ea)
@adamkondraciuk @nika-nordic
[nrf fromlist] drivers: spi: nrfx_spim: Add support for device runtim…
d9755bd 
…e PM

Enable the device runtime power management on the SPIM shim.

Upstream PR #: 75715

Signed-off-by: Adam Kondraciuk <[email protected]>
Signed-off-by: Nikodem Kastelik <[email protected]>
@adamkondraciuk @nika-nordic
[nrf fromlist] tests: drivers: spi: nordic: add device PM runtime
2a8927c 
Add configuration for testing SPI with device runtime PM enabled
for nRF platforms.

Upstream PR #: 75715

Signed-off-by: Adam Kondraciuk <[email protected]>
Signed-off-by: Nikodem Kastelik <[email protected]>
@nika-nordic nika-nordic force-pushed the fix_spim120_s2ram_sdkzephyr branch from 78487f2 to 2a8927c Compare December 13, 2024 12:48
@nika-nordic
Copy link
Contributor Author

Fixed upstream PR and aligned this one

@nika-nordic nika-nordic requested a review from anangl December 13, 2024 12:48
@jukkar jukkar merged commit 51d538f into nrfconnect:main Dec 13, 2024
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kl-cruz kl-cruz kl-cruz approved these changes

@adamkondraciuk adamkondraciuk adamkondraciuk approved these changes

@nordic-segl nordic-segl nordic-segl approved these changes

@nordic-krch nordic-krch Awaiting requested review from nordic-krch

@masz-nordic masz-nordic Awaiting requested review from masz-nordic

@nordicjm nordicjm Awaiting requested review from nordicjm

@anangl anangl Awaiting requested review from anangl

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
ncs-2.9.0-nRF54H20-1
Development

Successfully merging this pull request may close these issues.