Remove leftover socket options #2504
Open
+17
−17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MirkoCovizzi
force-pushed
the
remove-leftover-socket-options
branch
2 times, most recently
from
52e3b62 to
654172c
Compare
rlubos
reviewed
Feb 17, 2025
MirkoCovizzi
force-pushed
the
remove-leftover-socket-options
branch
2 times, most recently
from
da70969 to
99c1bcd
Compare
eivindj-nordic
approved these changes
Feb 17, 2025
MirkoCovizzi
force-pushed
the
remove-leftover-socket-options
branch
from
99c1bcd to
1fbfbc6
Compare
rlubos
approved these changes
Feb 17, 2025
MirkoCovizzi
force-pushed
the
remove-leftover-socket-options
branch
4 times, most recently
from
c1a4e5b to
72ab7b6
Compare
lemrey
reviewed
Feb 20, 2025
| /* NCS specific TLS level socket options */ | ||
|
|
||
| /** Socket option to set DTLS handshake timeout, specifically for nRF sockets. | ||
| * The option accepts an integer, indicating the total handshake timeout, | ||
| * including retransmissions, in seconds. | ||
| * Accepted values for the option are: 1, 3, 7, 15, 31, 63, 123. | ||
| */ | ||
| #define TLS_DTLS_HANDSHAKE_TIMEO 18 | ||
| #define TLS_DTLS_HANDSHAKE_TIMEO (NET_SOCKET_NCS_BASE + 18) |
There was a problem hiding this comment.
side note, did we not have a SO_ prefix or similar for these?
MirkoCovizzi
force-pushed
the
remove-leftover-socket-options
branch
from
72ab7b6 to
240cfe2
Compare
lemrey
approved these changes
Feb 20, 2025
nrf-squash! [nrf noup] include: net: add NCS extensions Removes leftover socket options `TLS_SESSION_CACHE_DISABLED` and `TLS_SESSION_CACHE_ENABLED`. These exist already in `socket.h`. Signed-off-by: Mirko Covizzi <[email protected]>
nrf-squash! [nrf noup] include: net: add NCS extensions Adds a base value for NCS specific socket options to prevent overlaps with Zephyr's socket options. Signed-off-by: Mirko Covizzi <[email protected]>
MirkoCovizzi
force-pushed
the
remove-leftover-socket-options
branch
from
240cfe2 to
7b749f0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removes leftover socket options
TLS_SESSION_CACHE_DISABLEDand
TLS_SESSION_CACHE_ENABLED. These exist alreadyin
socket.h.Adds a base value for NCS specific socket options to
prevent overlaps with Zephyr's socket options.