Remove legacy storage.hex generation #106
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently multiple storage_<domain>.hex files are created and flashed, a single storage.hex is deprecated. Signed-off-by: Artur Hadasz <[email protected]>
adsz-nordic
approved these changes
Apr 19, 2024
tomchy
reviewed
Apr 22, 2024
|
|
||
| ENVELOPE_SLOT_VERSION = 1 | ||
| ENVELOPE_SLOT_VERSION_KEY = 0 | ||
| ENVELOPE_SLOT_CLASS_ID_OFFSET_KEY = 1 | ||
| ENVELOPE_SLOT_ENVELOPE_BSTR_KEY = 2 | ||
|
|
||
| _LAYOUT = [ |
There was a problem hiding this comment.
I think it would be better to leave it empty, but at least leave it defined.
There was a problem hiding this comment.
EnvelopeStorage is a parrent class for EnvelopeStorageNrf54h20 class and uses _LAYOUT variable in some methods so it would be good to leve it empty or assign None value.
robertstypa
requested changes
Apr 30, 2024
|
|
||
| ENVELOPE_SLOT_VERSION = 1 | ||
| ENVELOPE_SLOT_VERSION_KEY = 0 | ||
| ENVELOPE_SLOT_CLASS_ID_OFFSET_KEY = 1 | ||
| ENVELOPE_SLOT_ENVELOPE_BSTR_KEY = 2 | ||
|
|
||
| _LAYOUT = [ |
There was a problem hiding this comment.
EnvelopeStorage is a parrent class for EnvelopeStorageNrf54h20 class and uses _LAYOUT variable in some methods so it would be good to leve it empty or assign None value.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently multiple storage_.hex files are
created and flashed, a single storage.hex is deprecated.