Attach Nordic-top to the Root manifest #91
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adsz-nordic
changed the title
adsz-nordic
force-pushed
the
ncsdk-25613
branch
from
f829298
to
fbc7ce1
Compare
adsz-nordic
requested review from
SylwesterKonczyk,
ahasztag and
kszromek-nordic
|
pytest coverage results
Note: This message is automatically posted and updated by the CI (HCS/test-sdk-dfu/master/668) |
ncs/sysctrl_envelope.yaml.jinja2
Outdated
| suit-invoke: | ||
| - suit-directive-set-component-index: 0 | ||
| - suit-directive-override-parameters: | ||
| suit-parameter-image-size: | ||
| file: {{ sysctrl['binary'] }} | ||
| - suit-condition-image-match: [] | ||
| # TODO: Uncomment once SysCtrl booting is done using SUIT - NCSDK-25614 | ||
| # - suit-condition-image-match: [] | ||
| - suit-directive-invoke: [] |
There was a problem hiding this comment.
- suit-directive-invoke:
That on shall be commented out as well, if Sysctl sahll NOT be booted using SUIT
There was a problem hiding this comment.
Thanks for spotting this. I will comment this out.
BTW - I'm disabling this because with current implementation where SDFW starts SCFW, the attempt to boot SCFW ended up with reboots.
robertstypa
approved these changes
Feb 16, 2024
| - RFC4122_UUID: | ||
| namespace: nordicsemi.com | ||
| name: nRF54H20_sec | ||
| - - INSTLD_MFST |
There was a problem hiding this comment.
Is there a possibility that there will be a build in which there will be only secdom available and sysctl should be removed from the output yaml file - in meaning that we should add here condition to check if sysctrl is defined?
ahasztag
approved these changes
Feb 16, 2024
kszromek-nordic
approved these changes
Feb 19, 2024
tomchy
reviewed
Feb 20, 2024
adsz-nordic
force-pushed
the
ncsdk-25613
branch
from
73619e0
to
81586e7
Compare
tomchy
reviewed
Feb 20, 2024
Adjust Kconfig to support the manifest hierarchy. Add nordic-top envelope template. Add root envelope tampate that uses nordic-top. Disable SysCtrl booting in sysctrl template until SUIT is used for booting it. Signed-off-by: Adam Szczygieł <[email protected]>
adsz-nordic
force-pushed
the
ncsdk-25613
branch
from
81586e7
to
c154d1d
Compare
robertstypa
approved these changes
Feb 20, 2024
tomchy
approved these changes
Feb 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NCSDK-25613