Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

suit: Migrate suit-text encoding #99

Merged

Conversation

tomchy
Copy link
Collaborator

@tomchy tomchy commented Mar 18, 2024

With the manifest specification version 24 the suit-text field has a language tag, so descriptions in multiple languages can be added.

@NordicBuilder
Copy link
Collaborator

NordicBuilder commented Mar 18, 2024

pytest coverage results

Detailed report:

Type Coverage
lines 93.3% (1884 of 2020 lines)
functions no data found
branches no data found

Note: This message is automatically posted and updated by the CI (HCS/test-sdk-dfu/bugfix%2Fsuit%2FNCSDK-NONE_Fix_text_field_encoding/6)

@kszromek-nordic
Copy link
Collaborator

I have an impression that names (not actual representations) for SUIT_Text_Map and SUIT_Text_LMap are the other way around.
Reference: https://github.com/nrfconnect/suit-processor/blob/main/cddl/manifest25.cddl#L31

With the manifest specification version 24 the suit-text field has a
language tag, so descriptions in multiple languages can be added.

Signed-off-by: Tomasz Chyrowicz <[email protected]>
@tomchy tomchy force-pushed the bugfix/suit/NCSDK-NONE_Fix_text_field_encoding branch from 0918c5b to 7117323 Compare March 19, 2024 08:47
@tomchy
Copy link
Collaborator Author

tomchy commented Mar 19, 2024

I have an impression that names (not actual representations) for SUIT_Text_Map and SUIT_Text_LMap are the other way around. Reference: https://github.com/nrfconnect/suit-processor/blob/main/cddl/manifest25.cddl#L31

Changed to match the names from CDDL.

@tomchy tomchy merged commit 602776e into nrfconnect:main Mar 19, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants