Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Blueprint contents localisation #287

Merged
merged 68 commits into from
Feb 4, 2021

Conversation

gundelsby
Copy link
Member

@gundelsby gundelsby commented Jul 31, 2020

  • What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
    i18n data contained in blueprint bundles is added to the existing translator function in core, making it possible to have localised content in blueprint code

  • Other information:
    Changes in the blueprints project:
    https://github.com/nrkno/tv-automation-sofie-blueprints/pull/65

Status

  • The functionality has been tested by the PR author
  • The functionality has been tested by NRK

@gundelsby gundelsby requested a review from jstarpl July 31, 2020 15:49
@gundelsby gundelsby closed this Aug 6, 2020
@gundelsby gundelsby reopened this Aug 6, 2020
@gundelsby gundelsby mentioned this pull request Aug 6, 2020
2 tasks
@gundelsby gundelsby self-assigned this Aug 12, 2020
Copy link
Member

@jstarpl jstarpl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it might be worth to convert the subscription/reactive query to a periodic method call, as this might be a pretty substantial subscription (in terms of memory size).

meteor/client/ui/i18n.ts Show resolved Hide resolved
meteor/server/api/blueprints/api.ts Outdated Show resolved Hide resolved
meteor/server/api/ingest/bucketAdlibs.ts Outdated Show resolved Hide resolved
@codecov-commenter
Copy link

codecov-commenter commented Sep 4, 2020

Codecov Report

Merging #287 into release25 will decrease coverage by 0.03%.
The diff coverage is 45.83%.

Impacted file tree graph

@@              Coverage Diff              @@
##           release25     #287      +/-   ##
=============================================
- Coverage      68.12%   68.08%   -0.04%     
=============================================
  Files            186      188       +2     
  Lines          12518    12556      +38     
  Branches        2777     2786       +9     
=============================================
+ Hits            8528     8549      +21     
- Misses          3922     3938      +16     
- Partials          68       69       +1     
Impacted Files Coverage Δ
meteor/lib/api/notes.ts 100.00% <ø> (ø)
meteor/lib/api/rundown.ts 61.29% <0.00%> (ø)
meteor/lib/collections/Parts.ts 50.90% <0.00%> (ø)
meteor/server/api/ingest/rundownInput.ts 70.09% <ø> (ø)
meteor/server/api/translationsBundles.ts 20.00% <20.00%> (ø)
meteor/server/api/blueprints/postProcess.ts 68.57% <50.00%> (-1.00%) ⬇️
meteor/server/api/ingest/bucketAdlibs.ts 30.76% <50.00%> (+1.60%) ⬆️
meteor/server/api/blueprints/api.ts 92.47% <66.66%> (-1.85%) ⬇️
meteor/server/api/blueprints/context/context.ts 81.31% <66.66%> (+0.20%) ⬆️
meteor/lib/api/pubsub.ts 93.61% <100.00%> (+0.13%) ⬆️
... and 6 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f3b2f59...e24cd81. Read the comment docs.

@gundelsby gundelsby changed the base branch from release23 to release25 September 7, 2020 08:52
@sonarqubecloud
Copy link

SonarCloud Quality Gate failed.

Bug C 1 Bug
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 20 Code Smells

No Coverage information No Coverage information
6.6% 6.6% Duplication

@gundelsby gundelsby marked this pull request as ready for review February 1, 2021 14:15
@gundelsby
Copy link
Member Author

This is now working, so I've converted the PR from a draft and will start working on the QA taking into consideration the previous comments from @jstarpl and @nytamin that are still valid.

@gundelsby gundelsby requested a review from nytamin February 2, 2021 16:34
meteor/client/ui/i18n.ts Show resolved Hide resolved
meteor/lib/api/userActions.ts Outdated Show resolved Hide resolved
meteor/server/api/translationsBundles.ts Outdated Show resolved Hide resolved
meteor/server/api/userActions.ts Outdated Show resolved Hide resolved
@jstarpl
Copy link
Member

jstarpl commented Feb 4, 2021

@gundelsby Looks good to me!

@gundelsby gundelsby merged commit 3a6604c into release30 Feb 4, 2021
@Julusian Julusian deleted the feat/blueprint-contents-localisation branch March 2, 2021 15:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants