-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Blueprint contents localisation #287
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it might be worth to convert the subscription/reactive query to a periodic method call, as this might be a pretty substantial subscription (in terms of memory size).
Codecov Report
@@ Coverage Diff @@
## release25 #287 +/- ##
=============================================
- Coverage 68.12% 68.08% -0.04%
=============================================
Files 186 188 +2
Lines 12518 12556 +38
Branches 2777 2786 +9
=============================================
+ Hits 8528 8549 +21
- Misses 3922 3938 +16
- Partials 68 69 +1
Continue to review full report at Codecov.
|
…ontents-localisation
…ontents-localisation
…or ICommonContext and IUserNotesContext Co-authored-by: Julian Waller <[email protected]>
…onTimelineGenerate and onAsRunEvent
SonarCloud Quality Gate failed. 1 Bug No Coverage information |
…ontents-localisation
Also, cache those bundles in localStorage so that we don't re-fetch them all the time.
…arts of the code that aren't immediately intuitive
@gundelsby Looks good to me! |
What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
i18n data contained in blueprint bundles is added to the existing translator function in core, making it possible to have localised content in blueprint code
Other information:
Changes in the blueprints project:
https://github.com/nrkno/tv-automation-sofie-blueprints/pull/65
Status