FIX: Openmedia Hotstandby disable heartbeat on primary when secondary is used

[olzzon]

About the Contributor

This PR is made on behalf of BBC

Type of Contribution

This is a:
Bug fix

Current Behavior

When Hot Standby is enabled:
Currently Heartbeat is not disabled on Primary if Secondary is connected and Primary disconnected.

New Behavior

Check for Secondary connection changes has been added, and heartbeat is set corresponding to that.

Tests has been updated:

The wrong test in Mosconnection.spec.ts has been removed, and the OpenMediaHotstandby.spec.ts test has been fixed with correct disconnection, and test for failover cases.

Testing Instructions

Run 2 parallel Open Media servers and disconnect the Primary.

Status

This PR has been test by author and only awaits BBC's final approval

• PR is ready to be reviewed.
• The functionality has been tested by the author.
• Relevant unit tests has been added / updated.
• Relevant documentation (code comments, system documentation) has been added / updated.

[codecov-commenter]

Codecov Report

Attention: Patch coverage is 80.00000% with 2 lines in your changes missing coverage. Please review.

Project coverage is 75.63%. Comparing base (562d74b) to head (28b5609).
Report is 9 commits behind head on master.

Files with missing lines	Patch %	Lines
packages/connector/src/MosConnection.ts	80.00%	2 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##           master     #110      +/-   ##
==========================================
- Coverage   75.87%   75.63%   -0.25%     
==========================================
  Files          67       68       +1     
  Lines        4009     4026      +17     
  Branches      948      950       +2     
==========================================
+ Hits         3042     3045       +3     
- Misses        943      980      +37     
+ Partials       24        1      -23     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.