Skip to content

Commit

Permalink
Merge pull request #100 from nrkno/ci/fix-signing-binaries
Browse files Browse the repository at this point in the history
ci: only try to sign .exe files
  • Loading branch information
nytamin authored Sep 8, 2023
2 parents 5f67200 + 5305841 commit bcd88c3
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions .github/workflows/build-windows.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -43,11 +43,11 @@ jobs:
# write certficate to file
echo "$WINDOWS_CERTIFICATE" | base64 -d > certificate.pfx
for FILE in deploy/*; do
for FILE in deploy/*.exe; do
echo "Trying to sign ${FILE}"
# This path is a bit fragile, but necessary as no signtool is on the path.
# If this path breaks, then find what versions of windows kits are installed in the updated runner image https://github.com/actions/runner-images#available-images
'C:/Program Files (x86)/Windows Kits/10/bin/10.0.17763.0/x86/signtool.exe' sign //fd SHA256 //f certificate.pfx //p "${{ secrets.WINDOWS_CERTIFICATE_PASSWORD }}" $FILE
echo $FILE
done
else
echo "No certificate found"
Expand Down

0 comments on commit bcd88c3

Please sign in to comment.