Fix: Silent ffmpeg bug (SOFIE-2650) #102
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was an issue where ffmpeg didn't output any progress reports for certain files. My findings show that it helps if we don't do the scene detection.
jstarpl
requested changes
Sep 28, 2023
| specificWorker: any | ||
| specificWorker: any, | ||
| /** An FYI, the work will be considered timed out if there are no progression reports within this interval*/ | ||
| progressTimeout: number |
There was a problem hiding this comment.
Is it reasonable to assume that all expectation will be able to provide periodical progress reports? I suspect that this will be the case for many of them, but if PM will be interacting with a remote system and having it do the operations, I expect it is quite likely that the API available may not provide progress reports or the progress report frequency may not be controllable. As such, wouldn't it make sense to move knowledge on the progressTimeout deeper into the expectations, so that they can make the judgement on what is an unacceptable amount of time to wait for a progress report?
… events, other than "error"
There was an issue in production when watching many files (over 9000), where chokidar choked on the initial watch and subsequently caused the whole worker to be sluggish
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(builds upon #101)
This PR attempts to fix a bug we've found where (for certain media files) ffmpeg doesn't output any progress messages
(
frame= 1 fps=0.2 q=-0.0 Lsize=N/A time=00:00:04.28 bitrate=N/A speed=0.722x speed= 1.8x)which PM uses to emit
progressevents.I have found that if we omit the scene detection from the ffmpeg command, it outputs the messages again.
So, if we detect that there are no progression events being emitted, we restart ffmpeg and try again, without the scene detection.
Additional information
Tested in prod-like environment and it seems to work well