Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat: JSON data copy (SOFIE-2763) #123

Merged
merged 15 commits into from
Jan 11, 2024
Merged

Feat: JSON data copy (SOFIE-2763) #123

merged 15 commits into from
Jan 11, 2024

Conversation

nytamin
Copy link
Contributor

@nytamin nytamin commented Nov 30, 2023 •
edited
Loading

This PR adds the JSON data copy expectation. (There was an implementation in there before which was not functional).

The JSONDataCopy expectation supports the sources LocalFolder, FileShare, HTTP, HTTPProxy and the targets LocalFolder, FileShare, HTTPProxy, CorePackageCollection.

(The HTTP -> CorePackageCollection pair is the one that warrants this PR)

@nytamin nytamin requested a review from a team November 30, 2023 08:13
jstarpl
jstarpl approved these changes Nov 30, 2023
View reviewed changes
Copy link
Member

@jstarpl jstarpl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, my only note would be a suggestion to rename isStable to isImmutable since "immutable" is the name used by HTTP protocol for this sort of effect.

shared/packages/api/src/inputApi.ts Outdated Show resolved Hide resolved
@nytamin nytamin requested a review from a team December 20, 2023 10:44
@nytamin nytamin merged commit 484a832 into master Jan 11, 2024
7 checks passed
@nytamin nytamin deleted the feat/json-data-copy branch January 11, 2024 07:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jstarpl jstarpl jstarpl approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nytamin @jstarpl @Julusian