Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: better support split deployment #205

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

Julusian
Copy link
Member

@Julusian Julusian commented Dec 16, 2024

About Me

This pull request is posted on behalf of the BBC

Type of Contribution

This is a: Bug fix / Code improvement

New Behavior

This makes a couple of changes:

  1. Fix the subscriptions to work when the header authentication is enabled in sofie. Note: this requires updating server-core-integration to compile.
  2. Add more docker images to better cater to split deployment
  3. Reworks the docker image CI to utilise build matrices to reduce duplication in the logic (this has not been tested because it is only set to run for tags)

Testing Instructions

Other Information

The docker image pushing needs some testing, but we are not setup to test this in the BBC fork, so I don't know how best to go about this

Status

  • PR is ready to be reviewed.
  • The functionality has been tested by the author.
  • Relevant unit tests has been added / updated.
  • Relevant documentation (code comments, system documentation) has been added / updated.

@Julusian Julusian added the Contributions from BBC Contributions sponsored by BBC (bbc.co.uk) label Dec 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Contributions from BBC Contributions sponsored by BBC (bbc.co.uk)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant