feat: linux support #86
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I did a local test of this just now, using Windows 10 to test for regressions. It seems to work well. |
nytamin
approved these changes
Jan 29, 2024
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was the minimal changes needed to get package-manager running on linux, and able to perform the full workflow copying between local folders.
I don't know if the ffmpeg command string changes will work on windows, but they were necessary on linux, otherwise ffmpeg rejected everything.
Because the
FILE_SHAREaccessor is heavily based onwindows-network-share, I took the lazy route of explicitly blocking that for now. Hopefully later an alternate version can be implemented, but that was more than I needed today.I haven't moved any of the code out of
WindowsWorker, perhaps it should be renamed toGenericWorkernow?