Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: read script from sofie ExpectedPackages, and write script edits back to sofie PackageInfos SOFIE-2846 #8

Merged
merged 4 commits into from
Mar 7, 2024

Conversation

Julusian
Copy link
Member

About the Contributor

This pull request is posted on behalf of the NRK.

Type of Contribution

This is a: Feature

New Behavior

Script edits are now written back to Sofie as PackageInfos.

To achieve this, each Part needs to have a script Piece (with a stable id), that has an ExpectedPackage.
PackageInfos will be written back against that ExpectedPackage.
Blueprints are then able to watch for the PackageInfos to edit the script shown in the Sofie UI. This prompter editor will use the PackageInfos as the source of script whenever possible.

Note: If piece/package ids are not stable, that can cause issues with edits being lost or reverted unexpectedly.

Whenever the contentVersionHash of the ExpectedPackages change, any edits performed on that will be ignored (but the PackageInfos will not be deleted), in effect reverting back to the NRCS version of the script.

Testing Instructions

Other Information

Status

  • PR is ready to be reviewed.
  • The functionality has been tested by the author.
  • Relevant unit tests has been added / updated.
  • Relevant documentation (code comments, system documentation) has been added / updated.

@Julusian Julusian marked this pull request as ready for review February 21, 2024 16:53
@Julusian Julusian requested a review from a team February 21, 2024 16:53
@Julusian Julusian merged commit 804e064 into main Mar 7, 2024
18 checks passed
@Julusian Julusian deleted the feat/save-to-core branch March 7, 2024 13:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants