fix: rework how subscriptions are set up (SOFIE-2973) #9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Now, the subscription methods returns an initial data set, which helps the GUI to reliably sync the initial data and resubscribe for following events
This fixes an issue where the server would unnessecarily unsubscribe and resubscribe immediately after
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now, the subscription methods returns an initial data set, which helps the GUI to reliably sync the initial data and resubscribe for following events
About the Contributor
This pull request is posted on behalf of the NRK.
Type of Contribution
This is a: Bug fix
Current Behavior
When the client loses connection and then reconnects, it resubscibes to the data, but any data changes that happened while it was disconnected won't be re-synced.
New Behavior
When resubscribing, the subscription methods now return the latest data set, helping the client to re-sync.
Also, a fix for the server unsubbing and resubbbing to the Core data immediately after.
Testing Instructions
Other Information
Status