Added Cuprite adapter #53
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
houndci-bot
reviewed
Nov 18, 2020
|
Thoughts on this @nruth ? The bot has some complains but IIRC the files are based on the existing adapters/tests and follow the same style. |
|
I'm not familiar with cuprite, but first impressions are that it looks ok to add. I'll take another look. Have you been using this registered as a custom driver? Does that work ok? |
|
Yes I am using it. Rebased and added webrick commit for Ruby 3. However I was unable to run all tests now due to some Firefox issue |
Bumps [addressable](https://github.com/sporkmonger/addressable) from 2.7.0 to 2.8.0. - [Release notes](https://github.com/sporkmonger/addressable/releases) - [Changelog](https://github.com/sporkmonger/addressable/blob/main/CHANGELOG.md) - [Commits](sporkmonger/addressable@addressable-2.7.0...addressable-2.8.0) --- updated-dependencies: - dependency-name: addressable dependency-type: indirect ... Signed-off-by: dependabot[bot] <[email protected]>
This gem exposes no executables and test_files is not used by RubyGems.org.
I think there was a hard space, so I removed it and added a formatting newline.
require false in gemfile as per its install instructions
Exclude the top-level DSL from Object and such; require the top-level RSpec constructs to start with "RSpec.".
SVG badges are... pretty.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.