Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(angular-rspack): add unit tests to with configurations #10

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

BioPhoton
Copy link
Collaborator

@BioPhoton BioPhoton commented Mar 9, 2025

This PR includes:

  • refined unit tests for createConfig

# Conflicts:
#	packages/angular-rspack/src/lib/config/create-config.ts
#	packages/angular-rspack/src/lib/config/create-config.unit.test.ts
Copy link

nx-cloud bot commented Mar 9, 2025

View your CI Pipeline Execution ↗ for commit 540f645.

Command Status Duration Result
nx-cloud record -- pnpm check-commit ✅ Succeeded 1s View ↗

☁️ Nx Cloud last updated this comment at 2025-03-09 11:46:53 UTC

@BioPhoton BioPhoton requested a review from Coly010 March 9, 2025 11:47
@Coly010 Coly010 force-pushed the main branch 7 times, most recently from bb3b981 to 12a4f2a Compare March 12, 2025 14:00
Copy link
Collaborator

@Coly010 Coly010 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems to be some conflicts that need resolved

);
};

describe('withConfigurations', () => {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This needs renamed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants