Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(angular-rspack): improve createConfig public api #35

Merged
merged 2 commits into from
Mar 12, 2025
Merged

feat(angular-rspack): improve createConfig public api #35

merged 2 commits into from
Mar 12, 2025

Conversation

leosvelperez
Copy link
Member

Update createConfig public API:

  • set all options as optional and normalize them accordingly
  • add all currently unsupported options and warn when used

@leosvelperez leosvelperez self-assigned this Mar 12, 2025
@nx-cloud Nx Cloud
Copy link

nx-cloud bot commented Mar 12, 2025 •
edited
Loading

View your CI Pipeline Execution ↗ for commit 9b029d5.

Command Status Duration Result
nx-cloud record -- pnpm check-commit ✅ Succeeded 1s View ↗

☁️ Nx Cloud last updated this comment at 2025-03-12 10:05:01 UTC

@leosvelperez leosvelperez merged commit 9e8d94e into main Mar 12, 2025
4 checks passed
@leosvelperez leosvelperez deleted the feat/improve-create-config-api branch March 12, 2025 10:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Coly010 Coly010 Coly010 approved these changes

Assignees

@leosvelperez leosvelperez

Labels
📖 documentation 🧪 testing
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@leosvelperez @Coly010