Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs(nx-dev): article about TypeScript monorepo package linking strategies #29694

Merged
merged 1 commit into from
Jan 28, 2025
Merged

docs(nx-dev): article about TypeScript monorepo package linking strategies #29694

merged 1 commit into from
Jan 28, 2025

Conversation

juristr
Copy link
Member

@juristr juristr commented Jan 21, 2025 •
edited
Loading

https://nx-dev-git-nxdev-blog-ts-linking-nrwl.vercel.app/blog/managing-ts-packages-in-monorepos

Some things to update still:

  • Is "linking" the right term 🤔
  • Alternative titles
    • Connecting TypeScript Packages in Monorepos
    • Strategies for Resolving TypeScript Package Dependencies in Monorepos
    • Managing TypeScript Packages in Monorepos
    • Structure and Share TypeScript Packages in Monorepos
    • Organizing TypeScript Packages in Monorepos

@vercel Vercel
Copy link

vercel bot commented Jan 21, 2025 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
nx-dev ✅ Ready (Inspect) Visit Preview Jan 28, 2025 11:39am

@juristr juristr requested a review from a team as a code owner January 21, 2025 10:28
@juristr juristr requested a review from isaacplmann January 21, 2025 10:28
@juristr juristr self-assigned this Jan 21, 2025
@nx-cloud Nx Cloud
Copy link

nx-cloud bot commented Jan 21, 2025 •
edited
Loading

View your CI Pipeline Execution ↗ for commit ec748e9.

Command Status Duration Result
nx affected --targets=lint,test,build,e2e,e2e-c... ✅ Succeeded 3m 20s View ↗
nx run-many -t check-imports check-commit check... ✅ Succeeded 59s View ↗
nx-cloud record -- nx-cloud conformance:check ✅ Succeeded 1s View ↗
nx-cloud record -- nx format:check --base=5127c... ✅ Succeeded 22s View ↗
nx-cloud record -- nx sync:check ✅ Succeeded 20s View ↗
nx documentation --no-dte ✅ Succeeded 42s View ↗

☁️ Nx Cloud last updated this comment at 2025-01-28 11:40:04 UTC

@juristr juristr added the PR status: do not merge This will block a PR from being merged until this tag is removed. label Jan 21, 2025
@juristr juristr force-pushed the nxdev/blog-ts-linking branch from b6ca9e0 to d1a4f57 Compare January 21, 2025 10:41
@juristr juristr force-pushed the nxdev/blog-ts-linking branch from d1a4f57 to 5ee4850 Compare January 21, 2025 14:33
@juristr juristr force-pushed the nxdev/blog-ts-linking branch from 5ee4850 to b22ccba Compare January 21, 2025 14:52
isaacplmann
isaacplmann approved these changes Jan 21, 2025
View reviewed changes
Copy link
Collaborator

@isaacplmann isaacplmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Only minor comment is the headings should have consistent capitalization. Either make them all sentence capitalization or all title capitalization

@juristr juristr force-pushed the nxdev/blog-ts-linking branch from b22ccba to 99288ef Compare January 21, 2025 19:27
leosvelperez
leosvelperez reviewed Jan 22, 2025
View reviewed changes
docs/blog/2025-01-20-linking-ts-in-monorepos.md Outdated Show resolved Hide resolved
docs/blog/2025-01-20-linking-ts-in-monorepos.md Outdated Show resolved Hide resolved
docs/blog/2025-01-20-linking-ts-in-monorepos.md Outdated Show resolved Hide resolved
docs/blog/2025-01-20-linking-ts-in-monorepos.md Outdated Show resolved Hide resolved
docs/blog/2025-01-20-linking-ts-in-monorepos.md Outdated Show resolved Hide resolved
docs/blog/2025-01-20-linking-ts-in-monorepos.md Outdated Show resolved Hide resolved
docs/blog/2025-01-20-linking-ts-in-monorepos.md Outdated Show resolved Hide resolved
docs/blog/2025-01-20-linking-ts-in-monorepos.md Outdated Show resolved Hide resolved
docs/blog/2025-01-20-linking-ts-in-monorepos.md Outdated Show resolved Hide resolved
docs/blog/2025-01-20-linking-ts-in-monorepos.md Outdated Show resolved Hide resolved
JamesHenry
JamesHenry requested changes Jan 22, 2025
View reviewed changes
Copy link
Collaborator

@JamesHenry JamesHenry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Blocking on workspace protocol usage as discussed on slack

@juristr juristr force-pushed the nxdev/blog-ts-linking branch from aaed164 to c1c0d03 Compare January 22, 2025 16:41
@juristr juristr force-pushed the nxdev/blog-ts-linking branch from c1c0d03 to 2ef1bb2 Compare January 22, 2025 16:54
JamesHenry
JamesHenry requested changes Jan 22, 2025
View reviewed changes
Copy link
Collaborator

@JamesHenry JamesHenry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good! Just some final tweaks

docs/blog/2025-01-20-linking-ts-in-monorepos.md Outdated Show resolved Hide resolved
docs/blog/2025-01-20-linking-ts-in-monorepos.md Outdated Show resolved Hide resolved
docs/blog/2025-01-20-linking-ts-in-monorepos.md Outdated Show resolved Hide resolved
docs/blog/2025-01-20-linking-ts-in-monorepos.md Outdated Show resolved Hide resolved
docs/blog/2025-01-20-linking-ts-in-monorepos.md Outdated Show resolved Hide resolved
docs/blog/2025-01-20-linking-ts-in-monorepos.md Outdated Show resolved Hide resolved
docs/blog/2025-01-20-linking-ts-in-monorepos.md Outdated Show resolved Hide resolved
docs/blog/2025-01-20-linking-ts-in-monorepos.md Outdated Show resolved Hide resolved
docs/blog/2025-01-20-linking-ts-in-monorepos.md Outdated Show resolved Hide resolved
docs/blog/2025-01-20-linking-ts-in-monorepos.md Outdated Show resolved Hide resolved
@juristr juristr force-pushed the nxdev/blog-ts-linking branch from e9dd93c to 2f12682 Compare January 24, 2025 13:52
@juristr juristr force-pushed the nxdev/blog-ts-linking branch from 2f12682 to b8a9a2a Compare January 27, 2025 12:44
@juristr juristr force-pushed the nxdev/blog-ts-linking branch from b8a9a2a to 81e2996 Compare January 27, 2025 14:00
@juristr juristr removed the PR status: do not merge This will block a PR from being merged until this tag is removed. label Jan 27, 2025
@juristr juristr force-pushed the nxdev/blog-ts-linking branch from 81e2996 to 2410ab8 Compare January 28, 2025 10:57
@juristr juristr enabled auto-merge (rebase) January 28, 2025 10:59
@juristr juristr disabled auto-merge January 28, 2025 11:14
@juristr juristr force-pushed the nxdev/blog-ts-linking branch from 2410ab8 to ec748e9 Compare January 28, 2025 11:30
@juristr juristr enabled auto-merge (rebase) January 28, 2025 11:31
@juristr juristr merged commit 4406a7e into master Jan 28, 2025
5 checks passed
@juristr juristr deleted the nxdev/blog-ts-linking branch January 28, 2025 11:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@leosvelperez leosvelperez leosvelperez approved these changes

@JamesHenry JamesHenry JamesHenry approved these changes

@isaacplmann isaacplmann isaacplmann approved these changes

@jaysoo jaysoo jaysoo approved these changes

Assignees

@juristr juristr

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@juristr @jaysoo @isaacplmann @JamesHenry @leosvelperez