Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "fix(core): support subpath exports when constructing the project graph" #29762

Merged
merged 1 commit into from
Jan 27, 2025

Conversation

jaysoo
Copy link
Member

@jaysoo jaysoo commented Jan 27, 2025

Reverts #29577

There is an issue with workspaces using tsconfig path alias, and when an invalid import is found, it'll match on the wrong package due to the name matching the prefix.

@jaysoo jaysoo requested a review from a team as a code owner January 27, 2025 16:12
@jaysoo jaysoo requested a review from FrozenPandaz January 27, 2025 16:12
Copy link

vercel bot commented Jan 27, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Skipped Deployment
Name Status Preview Updated (UTC)
nx-dev ⬜️ Ignored (Inspect) Visit Preview Jan 27, 2025 4:14pm

@nrwl nrwl deleted a comment from linear bot Jan 27, 2025
Copy link

nx-cloud bot commented Jan 27, 2025

View your CI Pipeline Execution ↗ for commit e08f4a7.

Command Status Duration Result
nx affected --targets=lint,test,build,e2e,e2e-c... ✅ Succeeded 34m 33s View ↗
nx run-many -t check-imports check-commit check... ✅ Succeeded 1m 6s View ↗
nx-cloud record -- nx-cloud conformance:check ✅ Succeeded 2s View ↗
nx-cloud record -- nx format:check --base=1a13a... ✅ Succeeded 27s View ↗
nx-cloud record -- nx sync:check ✅ Succeeded 26s View ↗
nx documentation --no-dte ✅ Succeeded 1m 15s View ↗

☁️ Nx Cloud last updated this comment at 2025-01-27 16:52:16 UTC

@jaysoo jaysoo enabled auto-merge (squash) January 27, 2025 16:38
@jaysoo jaysoo merged commit f02a88a into master Jan 27, 2025
6 checks passed
@jaysoo jaysoo deleted the revert-29577-fix/support-subpath-exports-in-graph branch January 27, 2025 16:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants