Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(remix): add continuous task support #29905

Merged
merged 1 commit into from
Feb 7, 2025

Conversation

Coly010
Copy link
Contributor

@Coly010 Coly010 commented Feb 6, 2025

Current Behavior

When serve, dev, start targets are inferred by the @nx/remix plugin, they are not inferring continuous.

Expected Behavior

When NX_CONTINUOUS_TASKS_PREVIEW env var exists, infer the continuous property.

@Coly010 Coly010 requested a review from a team as a code owner February 6, 2025 10:50
@Coly010 Coly010 requested a review from ndcunningham February 6, 2025 10:50
Copy link

vercel bot commented Feb 6, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Skipped Deployment
Name Status Preview Updated (UTC)
nx-dev ⬜️ Ignored (Inspect) Visit Preview Feb 7, 2025 9:11am

@Coly010 Coly010 self-assigned this Feb 6, 2025
Copy link

nx-cloud bot commented Feb 6, 2025

View your CI Pipeline Execution ↗ for commit 5ac41af.

Command Status Duration Result
nx affected --targets=lint,test,build,e2e,e2e-c... ✅ Succeeded 15m 28s View ↗
nx run-many -t check-imports check-commit check... ✅ Succeeded 22s View ↗
nx-cloud record -- nx-cloud conformance:check ✅ Succeeded 2s View ↗
nx-cloud record -- nx format:check --base= --he... ✅ Succeeded 13s View ↗
nx-cloud record -- nx sync:check ✅ Succeeded 10s View ↗
nx documentation ✅ Succeeded 2m 23s View ↗

☁️ Nx Cloud last updated this comment at 2025-02-06 17:37:28 UTC

@Coly010 Coly010 force-pushed the remix/continuous-tasks-support branch 2 times, most recently from d8f41ff to 259659c Compare February 6, 2025 14:04
packages/remix/src/plugins/plugin.ts Outdated Show resolved Hide resolved
packages/remix/src/plugins/plugin.ts Show resolved Hide resolved
@Coly010 Coly010 merged commit c188c5d into next-major Feb 7, 2025
12 checks passed
@Coly010 Coly010 deleted the remix/continuous-tasks-support branch February 7, 2025 09:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants