Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(nx-dev): webinar page #29913

Merged
merged 8 commits into from
Feb 7, 2025
Merged

feat(nx-dev): webinar page #29913

merged 8 commits into from
Feb 7, 2025

Conversation

isaacplmann
Copy link
Collaborator

Adds a webinar page and a script to pull the webinar content from Notion

@isaacplmann isaacplmann requested review from FrozenPandaz, vsavkin and a team as code owners February 6, 2025 17:35
Copy link

vercel bot commented Feb 6, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
nx-dev ✅ Ready (Inspect) Visit Preview Feb 7, 2025 7:20pm

Copy link

nx-cloud bot commented Feb 6, 2025

View your CI Pipeline Execution ↗ for commit e9c9412.

Command Status Duration Result
nx affected --targets=lint,test,build,e2e,e2e-c... ✅ Succeeded 23m 7s View ↗
nx run-many -t check-imports check-commit check... ✅ Succeeded 20s View ↗
nx-cloud record -- nx-cloud conformance:check ✅ Succeeded 2s View ↗
nx-cloud record -- nx format:check --base= --he... ✅ Succeeded 11s View ↗
nx-cloud record -- nx sync:check ✅ Succeeded 10s View ↗
nx documentation ✅ Succeeded 1m 30s View ↗

☁️ Nx Cloud last updated this comment at 2025-02-07 19:43:03 UTC

Copy link
Member

@juristr juristr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When opening a past webinar it doesn't link to anything

Screenshot 2025-02-07 at 15 13 58

Also the image on the right looks weird. Are we going to change it? Also the combination between the right-side image and the large preview of the upcoming webinar is strange. Maybe we don't even need an image on the right 🤔

Screenshot 2025-02-07 at 15 12 56

We should also link the page in the resources menu

image

@jaysoo jaysoo merged commit 33352bc into master Feb 7, 2025
11 of 12 checks passed
@jaysoo jaysoo deleted the nx-dev/webinars branch February 7, 2025 19:22
FrozenPandaz pushed a commit that referenced this pull request Feb 8, 2025
Adds a webinar page and a script to pull the webinar content from Notion

(cherry picked from commit 33352bc)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants