[#765] Adding ACA Rocky Container for CI System Tests #769
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… system tests; Added ACA-CI Dockerfile which has been pushed to registry; Renamed Provisioner for CI Dockerfile for consistency
iadgovuser29
approved these changes
May 10, 2024
iadgovuser26
approved these changes
May 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is meant to add an ACA container built from Rocky 9 specifically meant for System Tests in the CI. It also follows up on PR 748 to make minor additions to suit the new ACA containers, plus some improved comments and one renamed file.
The following files have been added/modified:
Dockerfile.aca-rocky-ciis the Dockerfile used to create an image for the ACA built from Rocky 9, specifically to be used with the CI System Tests. It differs fromDockerfile.aca-rockyby NOT using a CMD statement at the end of the Dockerfile (it is now commented out) to start the ACA; instead, the ACA scripts are called fromrun_system_tests.sh. However, if the user wanted to use the CMD statement and use the container for other purposes, they can uncomment it at the end of the file as specified by the commented instructions. Also, this image has already been pushed to the nsacyber/HIRS GitHub package registry asghcr.io/nsacyber/hirs/aca-rocky-ci:latest.Dockerfile.tpm2provisioner_dotnet(old name) has been renamed toDockerfile.tpm2provisioner-dotnet-ci(new name) to have a consistent naming convention, as withDockerfile.aca-rocky-ci. Also added some more comments to guide any users who want to build/run the container locally.run_system_tests.shnow calls for the execution of scripts to set up and start the ACA within the container pulled fromghcr.io/nsacyber/hirs/aca-rocky-ci:latest. It also checks out the current branch being pushed within the container's HIRS clone before starting the ACA. To confirm the branch for both the ACA and Provisioner, it will echo the current branch name within the HIRS cloned repo inside the containers, which will be output to the GitHub Action run (see lines 20 and 27 ofrun_system_tests.sh).docker-compose-system-test.ymlnow pulls the newghcr.io/nsacyber/hirs/aca-rocky-ci:latestimage.system_test.ymlnow has updated Action uses (v3 -> v4), removing a warning that was there previously.To perform the test in GitHub actions:
On this branch in remote repository, use a workflow dispatch by going: Actions > HIRS System Tests > Run workflow.