BIG REFACTOR #175
Closed
BIG REFACTOR #175
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
![ellipsis-dev[bot]](https://avatars.githubusercontent.com/in/64358?s=60&v=4){kind=small}
There was a problem hiding this comment.
A few small fixes required, otherwise good
Summary:
This PR involves a major refactoring that includes deleting and replacing components, renaming components, moving components to different directories, and updating file paths.
Key points:
- Deleted ErrorAlert component and replaced with a more generic Error component
- Refactored signUp function in SignUpForm to an arrow function
- Renamed DashboardMode component to Home
- Moved and renamed ErrorMode component to a shared directory
- Moved ResponsesTable component up one directory level
- Updated file paths in forms/[id] and home pages
Something look wrong? You can customize Ellipsis' behavior when reviewing code by editing the config file for this repository.
Generated with ❤️ by ellipsis.dev
| <form | ||
| className="space-y-6" | ||
| action="#" | ||
| method="POST" | ||
| onSubmit={onFormSubmit} | ||
| onSubmit={() => onFormSubmit} |
There was a problem hiding this comment.
The onFormSubmit function is not being called correctly. It should be passed as a reference, not invoked. Change onSubmit={() => onFormSubmit} to onSubmit={onFormSubmit}.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
This PR involves a major refactoring that includes deleting and replacing components, renaming components, moving components to different directories, and updating file paths.
Key points:
Generated with ❤️ by ellipsis.dev