Allow non-blocking reading of digests (with timeout=0) #76
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change lets us call
SimpleSwitchP4RuntimeAPI.get_digest_list
with very low timeout values, e.g.timeout=0
. Currently, a low timeout results in no digest being read (because the timeout is instantly over). With this fix, the timeout is not taken into account if no waiting is necessary because a digest is already available (because a digest has already been received previously).Motivation: I want to be able to read a digest from one of the switches in the network. If the digest reading is a blocking operation, then it takes a considerable amount of time to iterate over all switches. This simple patch allows users to use digest reading as a non blocking operation, without having to use sockets or
select.select
directly.