Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing tests that depends on diff between strings #32

Merged
merged 1 commit into from
Nov 1, 2012

Conversation

douglascamata
Copy link
Member

No description provided.

@hltbra
Copy link
Contributor

hltbra commented Jul 23, 2012

Wouldn't it break other python versions? This diff only breaks on python2.7 IIRC.

@douglascamata
Copy link
Member Author

Forgot to try it, will check it.

@rodrigomanhaes
Copy link
Member

tox summary output:

ERROR:   py24: commands failed
ERROR:   py25: commands failed
ERROR:   py26: commands failed
  py27: commands succeeded
  py32: commands succeeded

@douglascamata
Copy link
Member Author

OH GOD, WHY? What are we supposed to do now? Is there a way to run specific doctests just under some condition (the Python interpreter version)?

@hltbra
Copy link
Contributor

hltbra commented Jul 24, 2012

Take a look at #31, @douglascamata, it should tell you everything.

@hltbra
Copy link
Contributor

hltbra commented Sep 17, 2012

Any news, @douglascamata?

@douglascamata
Copy link
Member Author

Will take a look at this tonight and report back.

@rodrigomanhaes rodrigomanhaes merged commit 4410267 into nsi-iff:master Nov 1, 2012
@hltbra
Copy link
Contributor

hltbra commented Nov 1, 2012

@rodrigomanhaes, did you read my comments above? It solves for Python 2.7.2 and breaks for all other Python versions. See issue #31.

The new Python 2.7.3 release seems to fix it. So I would recommend reverting the change and updating your Python to 2.7.3 and see what happens.

@rodrigomanhaes
Copy link
Member

I'm too old for late night programming... :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants