Handle opening multi-file granules #394
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jrbourbeau
commented
Dec 4, 2023
| ) | ||
| ) | ||
|
|
||
| url_mapping = _get_url_granule_mapping(granules, access) |
There was a problem hiding this comment.
The basic idea here is we now construct this mapping from filename to granule that contains the file. Currently we just have a list of files and list of granules, which isn't quite what we need
jrbourbeau
changed the title
jrbourbeau
changed the title
betolink
approved these changes
Dec 4, 2023
There was a problem hiding this comment.
I just tested #394 and worked as expected, thanks @jrbourbeau !!
| return EarthAccessFile(fs.open(urls), granule) | ||
|
|
||
| fileset = pqdm(zip(data_links, granules), multi_thread_open, n_jobs=threads) | ||
| fileset = pqdm(url_mapping.items(), multi_thread_open, n_jobs=threads) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Marking as WIP as this doesn't handle all the open + download code paths yet and I think
mypyisn't happy right now either. Just wanted to get a quick +1 for this general direction before finishing up.Closes #393