Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace
poetry
withpip
, build withhatchling
, dynamically calculate minimum dependencies withuv
#733Replace
poetry
withpip
, build withhatchling
, dynamically calculate minimum dependencies withuv
#733Changes from 36 commits
1b7343b
f2e15ce
732abd1
a31b7ae
5704abb
82189e7
5b819a3
21be5f2
24a5191
edd6442
6ac66b7
a39a519
4c57306
cde7b85
5f5986f
6dada1a
8e8a7e7
8643011
bd3fe74
cadcbdd
e194f14
c0cf028
9818907
7c4eb2e
4409b11
bff4354
adbc43c
82381d7
87c22ea
c5c414e
f53b451
f96b5f0
d1b619d
df578ed
0923beb
54e0ae1
a6aee82
2cef7fb
de313be
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lockfile stays up-to-date without user needing to learn to use any new tooling
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This file wasn't documented or used anywhere.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Better also remove the
make test
step from docs/contributing/index.md.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
NICE FIND! How did I miss that!?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
0923beb ?
This file was deleted.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Will this install earthaccess from source in the Binder environment?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Correct, but not editable. We can change it to
"--editable ."
to achieve that if we want. I haven't tested this -- is there a way to test with Binder before merge tomain
?This file was deleted.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
To me, it doesn't make sense for this to be in the
ci
directory.This file was deleted.
This file was deleted.