rpcbindings: produce ToStackItem companion method #3794
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
roman-khimov
added
compiler
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #3794 +/- ##
==========================================
- Coverage 83.14% 83.06% -0.09%
==========================================
Files 335 335
Lines 46903 46988 +85
==========================================
+ Hits 38999 39031 +32
- Misses 6311 6367 +56
+ Partials 1593 1590 -3 ☔ View full report in Codecov by Sentry. |
roman-khimov
force-pushed
the
tostackitem
branch
2 times, most recently
from
10a71cd to
2f02b3e
Compare
AnnaShaleva
reviewed
Jan 24, 2025
Sometimes we may need something that doesn't panic. Signed-off-by: Roman Khimov <[email protected]>
We need it for structs to be usable as function parameters, otherwise
they're not implementing stackitam.Convertible and they fail at transaction
script creation phase:
2025/01/22 20:31:26 bootstrap error: could not invoke method (addNode): test invocation failed: unsupported operation: *netmap.NetmapNode2 type
Related to nspcc-dev/neofs-node#3088.
Signed-off-by: Roman Khimov <[email protected]>
roman-khimov
force-pushed
the
tostackitem
branch
from
2f02b3e to
00e22b9
Compare
AnnaShaleva
approved these changes
Jan 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We need it for structs to be usable as function parameters, otherwise they're not implementing stackitam.Convertible and they fail at transaction script creation phase:
Related to nspcc-dev/neofs-node#3088.