Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue 4 #5

Closed
wants to merge 3 commits into from
Closed

Issue 4 #5

wants to merge 3 commits into from

Commits on Apr 15, 2013

  1. Refactor and test connection handling and lookupd response handling.

    - Only reconnect to new nsqd instances in lookupd response, not all of them
    - Disconnect from removed nsqd instances in lookupd response.
    - Connections with errors call back to NSQReader.remove()
      (Connection.close() does not do this implicitly).
    - Add a unit test for NSQReader (and MockConnection class)
    - Add a unit test for SyncResponseReader (and MockHandler class)
    - Add some class and method comments
    - Fix typo in public method 'Connection.decodeMesage()'
    
    Refs Issue nsqio#3
    Andy O'Neill committed Apr 15, 2013
    Configuration menu
    Copy the full SHA
    44dca4e View commit details
    Browse the repository at this point in the history

Commits on Apr 16, 2013

  1. Move message encode/decode to utility class

    - New MessageCodec class
    - Also remove all import foo.* in non-test code.
    
    Refs Issue nsqio#4
    Andy O'Neill committed Apr 16, 2013
    Configuration menu
    Copy the full SHA
    966faec View commit details
    Browse the repository at this point in the history
  2. Remove import * in tests to comply with bitly standards.

    Andy O'Neill committed Apr 16, 2013
    Configuration menu
    Copy the full SHA
    2518cf3 View commit details
    Browse the repository at this point in the history