Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nsqd: remove --worker-id, replace with --node-id #844

Merged
merged 4 commits into from
Feb 6, 2017
Merged

nsqd: remove --worker-id, replace with --node-id #844

merged 4 commits into from
Feb 6, 2017

Commits on Jan 28, 2017

  1. nsqd: no longer need atomicRename() for windows 

    os.Rename() now does the same thing on Windows
that atomicRename() did (since go 1.5)
    @ploxiln
    ploxiln committed Jan 28, 2017
    Configuration menu
    Copy the full SHA
    95dac2a View commit details
    Browse the repository at this point in the history

  2. nsqd: rename option --worker-id to --node-id

    @ploxiln
    ploxiln committed Jan 28, 2017
    Configuration menu
    Copy the full SHA
    dead0da View commit details
    Browse the repository at this point in the history

  3. tests: ioutil.TempDir() adds a pseudo-random suffix 

    no need to add our own pseudo-random "unique" suffix
    @ploxiln
    ploxiln committed Jan 28, 2017
    Configuration menu
    Copy the full SHA
    34c7eb7 View commit details
    Browse the repository at this point in the history

  4. nsqd: new metadata filename without ID 

    symlink old metadata filename to new
when loading, if both exist, ensure they match
this makes rollback possible without losing messages
(when rolling back forward, some manual intervention is required)

on windows, Symlink() needs Administrator privs,
so just write plain old metadata file

includes tests
    @ploxiln
    ploxiln committed Jan 28, 2017
    Configuration menu
    Copy the full SHA
    3b4b6a5 View commit details
    Browse the repository at this point in the history