Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix progress view in iOS 8 or later #30

Merged
merged 1 commit into from
Oct 6, 2017
Merged

Fix progress view in iOS 8 or later #30

merged 1 commit into from
Oct 6, 2017

Conversation

JohnWong
Copy link
Contributor

@JohnWong JohnWong commented Oct 6, 2017

The progress view shown when load all frameworks did not work in iOS 8 or later. Using UIAlertController to replace UIAlertView will fix this issue, but the minimum version will be iOS 8.

Before:

simulator screen shot - iphone x - 2017-10-06 at 19 54 43

After:

simulator screen shot - iphone x - 2017-10-06 at 19 49 04

Side effect:

The minimum version will be iOS 8.

The progress view did not work in iOS 8 and later. Using UIAlertController to replace UIAlertView will fix this issue, but the minimum version will be iOS 8.
@JohnWong
Copy link
Contributor Author

JohnWong commented Oct 6, 2017

And this pr will fix issue #26

@nst nst merged commit d571a46 into nst:master Oct 6, 2017
@nst
Copy link
Owner

nst commented Oct 6, 2017

Thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants