Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Github] Run unit tests for all test platforms #742

Merged
merged 2 commits into from
Oct 10, 2023
Merged

[Github] Run unit tests for all test platforms #742

merged 2 commits into from
Oct 10, 2023

Conversation

Romfos
Copy link
Contributor

@Romfos Romfos commented Oct 2, 2023 •
edited
Loading

Changes:

  • Run build for different platforms and combinations (including .net 4.6.2 on windows)
  • Added .net 7 to testing platforms

note: no changes in product, no need to release new nuget packages

@Romfos Romfos marked this pull request as ready for review October 2, 2023 13:37
@Romfos Romfos changed the title Run unit tests for all test platforms [Github actions] Run unit tests for all test platforms Oct 2, 2023
@Romfos Romfos changed the title [Github actions] Run unit tests for all test platforms [Github] Run unit tests for all test platforms Oct 8, 2023
alexandrnikitin
alexandrnikitin approved these changes Oct 8, 2023
View reviewed changes
Copy link
Member

@alexandrnikitin alexandrnikitin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome! Thank you so much!

.github/workflows/build_and_test.yml Outdated
strategy:
matrix:
os: [ubuntu-latest, windows-latest, macOS-latest]
os: [windows-latest, ubuntu-latest, macOS-latest]
tfm: [net6.0, net7.0]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

q: maybe "framework" is clearer?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe, lets update

@alexandrnikitin alexandrnikitin merged commit 9a3540c into nsubstitute:main Oct 10, 2023
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexandrnikitin alexandrnikitin alexandrnikitin approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Romfos @alexandrnikitin