Merge pull request #119 from nswdpc/fix-iframe-haspolyfill

Iframe polyfill update
nswdpc · Sep 23, 2024 · a796a05 · a796a05
2 parents 32219a6 + eb39f4e
commit a796a05
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 3 deletions.
diff --git a/composer.json b/composer.json
@@ -53,7 +53,8 @@
         "nswdpc/silverstripe-grid-helpers": "^0.2",
         "nswdpc/silverstripe-datetime-inputs": "<1",
         "nswdpc/silverstripe-notices": "^0.1",
-        "nswdpc/silverstripe-analytics-chooser": "^0.2"
+        "nswdpc/silverstripe-analytics-chooser": "^0.2",
+        "nswdpc/silverstripe-elemental-iframe": ">=0.3.2 <1"
     },
     "require-dev": {
         "phpunit/phpunit": "^9.5",

diff --git a/themes/nswds/templates/NSWDPC/Elemental/Models/Iframe/ElementIframe.ss b/themes/nswds/templates/NSWDPC/Elemental/Models/Iframe/ElementIframe.ss
@@ -1,7 +1,7 @@
 <% include NSWDPC/Waratah/ElementTitle ShowTitle=$ShowTitle, Title=$Title, HeadingLevel=$HeadingLevel %>
 <div class="nsw-block">
 <div class="outer<% if $IsDynamic %> iframe-resizer<% end_if %><% if $IsResponsive %> responsive-iframe is-{$IsResponsive.XML}<% end_if %>">
-    <% if $IsLazy %><noscript class="loading-lazy"><% end_if %>
+    <% if $IsLazy && $HasPolyfill %><noscript class="loading-lazy"><% end_if %>
         <iframe
             <% if $AlternateContent %>title="{$AlternateContent.XML}"<% end_if %>
             class="<% if $IsDynamic %>dynamic-item<% end_if %><% if $IsResponsive %> responsive-item<% end_if %>"
@@ -13,6 +13,6 @@
             src="{$URL.LinkURL.XML}"
             frameborder="0">
         </iframe>
-    <% if $IsLazy %></noscript><% end_if %>
+    <% if $IsLazy && $HasPolyfill %></noscript><% end_if %>
 </div>
 </div>