Support ANNOUNCE_OK and ANNOUNCE_ERROR handler #116
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## impl/subscribe_namespace_handler #116 +/- ##
====================================================================
- Coverage 69.24% 68.23% -1.02%
====================================================================
Files 55 58 +3
Lines 2725 2814 +89
====================================================================
+ Hits 1887 1920 +33
- Misses 838 894 +56
|
yuki-uchida
approved these changes
Oct 29, 2024
| @@ -4,6 +4,8 @@ use crate::constants::TerminationErrorCode; | |||
| use crate::modules::handlers::{ | |||
| announce_handler::AnnounceResponse, unannounce_handler::unannounce_handler, | |||
| }; | |||
| use crate::modules::server_processes::announce_error_message::process_announce_error_message; | |||
* add todo comment * refactor: add error handling * feat: announce propagate * refactor: error message * Support new messages relay feature (#120) * feat: relay new messages * feat: send subscribe namespace ok * Support client send/recv SUBSCRIBE_NAMESPACE (#121) * feat: send/recv subscribe_namespace * Merge branch 'impl/new_message_relay' into impl/client/subscribe_namespace * delete: unnecessary parameter * fix: handle multiple control message * feat: send announce ok message * refactor: send/recv log
…ttcom/moq-wasm into impl/announce_responce_handler
tetter27
added a commit
that referenced
this pull request
Oct 30, 2024
* impl: update version to 06 * fix: mark ANNOUNCE_ERROR * fix: change default value to 06 * fix: wrong item text * add field for 06 * fix: typo * refactor: delete unnecessary comment * refactor: delete unnecessary comment * refactor: delete unnecessary comment * feat: subscribe_namespace message * refactor: delete unnecessary param * feat: get parameter * refactor: delete unnecessary param * feat: subscribe namespace * fix: behavior along with draft * add tests * Support ANNOUNCE_OK and ANNOUNCE_ERROR handler (#116) * feat: handle announce responce * Propagate announce if the namespace was subscribed by subscribers (#117) * add todo comment * refactor: add error handling * feat: announce propagate * refactor: error message * Support new messages relay feature (#120) * feat: relay new messages * feat: send subscribe namespace ok * Support client send/recv SUBSCRIBE_NAMESPACE (#121) * feat: send/recv subscribe_namespace * Merge branch 'impl/new_message_relay' into impl/client/subscribe_namespace * delete: unnecessary parameter * fix: handle multiple control message * feat: send announce ok message * refactor: send/recv log * refactor: import grouping
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This feature was TODO of #115