Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Separate Uni Stream Receiver function #135

Merged
merged 1 commit into from
Dec 15, 2024
Merged

Separate Uni Stream Receiver function #135

merged 1 commit into from
Dec 15, 2024
+259 −162

Conversation

tetter27
Copy link
Collaborator

  • Defined UniStreamReceiver class
  • Integrated two loops
    • Read webtrans data and write to buf
    • Read buf and store to Object Cache Storage

@tetter27 tetter27 requested a review from yuki-uchida December 10, 2024 04:44
@codecov Codecov
Copy link

codecov bot commented Dec 10, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 0.71942% with 138 lines in your changes missing coverage. Please review.

Project coverage is 63.58%. Comparing base (dcdf058) to head (34c478e).
Report is 2 commits behind head on refactor/separate_moqt-server_fn.

Additional details and impacted files 
@@                         Coverage Diff                          @@
##           refactor/separate_moqt-server_fn     #135      +/-   ##
====================================================================
- Coverage                             64.12%   63.58%   -0.54%     
====================================================================
  Files                                    73       73              
  Lines                                  3381     3422      +41     
====================================================================
+ Hits                                   2168     2176       +8     
- Misses                                 1213     1246      +33
Components Coverage Δ
moqt-core 91.19% <ø> (ø)
moqt-server 52.92% <0.71%> (-0.58%) ⬇️

yuki-uchida
yuki-uchida requested changes Dec 10, 2024
View reviewed changes
Copy link
Collaborator

@yuki-uchida yuki-uchida left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What are your thoughts on the point that CI is failed?

yuki-uchida
yuki-uchida approved these changes Dec 11, 2024
View reviewed changes
Copy link
Collaborator

@yuki-uchida yuki-uchida left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tests will be added at other PR

@tetter27 tetter27 merged commit ab8dc29 into refactor/separate_moqt-server_fn Dec 15, 2024
6 of 9 checks passed
@tetter27 tetter27 deleted the refactor/separate_fn branch December 15, 2024 06:59
tetter27 added a commit that referenced this pull request Dec 16, 2024
@tetter27
Separate moqt-server/lib.rs (#134)
36638dc 
* refactor: separate lib.rs

* refactor: session_handler as class

* fix: indicated items

* separate fn in uni stream receiver (#135)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yuki-uchida yuki-uchida yuki-uchida approved these changes

Assignees
No one assigned
Labels
refactoring
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tetter27 @yuki-uchida