Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Python 3.10 Support and Fix Compilation Issues #194

Open
wants to merge 14 commits into
base: master
Choose a base branch
from
Open

Add Python 3.10 Support and Fix Compilation Issues #194

wants to merge 14 commits into from

Conversation

CoolJosh0221
Copy link

@CoolJosh0221 CoolJosh0221 commented Dec 24, 2024 •
edited
Loading

Description

This pull request includes several key updates to the libact package:

  1. Python 3.10 Support:
    • Added compatibility for Python 3.10.
  2. Compilation Fixes in libact/query_strategies/_hintsvm.pyx:
    • Resolved syntax errors to ensure successful compilation.
  3. Updated Installation Instructions in README.md:
    • Revised steps to include Python 3.10 setup.
  4. Runtime Error Fixes:
    • Addressed various runtime errors caused by version changes, as detected by the tests.
  5. Test Case Updates:
    • Updated test cases to align with the latest package versions.

CoolJosh0221 and others added 14 commits December 21, 2024 09:50
@CoolJosh0221
1. Modified _hintsvm.pyx and successfully compiled the source code
489a1fe 
2. Modified README.md (changed the order of installing dependencies && changed the installation method)
@CoolJosh0221
Updated plot.py
48f63b4
@CoolJosh0221
Removed unnecessary comment in libact/query_strategies/tests/test_den…
38d1fce 
…sity_weighted_meta.py
@CoolJosh0221
Update README.md and revert unnecessary changes
5e50bc1
@CoolJosh0221
Update README.md and libact/base/dataset.py
d426091 
Current Status: 2 of the tests fail and 1 throws an error
@CoolJosh0221
Fix the NearestNeighbors error in libact/query_strategies/multilabel/…
add6c1a 
…cost_sensitive_reference_pair_encoding.py
@CoolJosh0221
Update test cases and specify module versions in requirements.txt
bf283c9
@ariapoy
Update unittest and coverage usage
702eddf 
Resolve the [Deprecate test command](pypa/setuptools#1684) in `setuptools`.
@ariapoy
Update .gitignore
f37508b
@ariapoy
Restore plot.py
ed2d8ec
@ariapoy
Update dataset.py
86746a1
@ariapoy
Update density_weighted_meta.py
3caf4de
@ariapoy
Update density_weighted_uncertainty_sampling.py
5da9d0e
@CoolJosh0221
Update setup.py
0a0d06e
@ariapoy
Copy link
Collaborator

ariapoy commented Mar 23, 2025

@yangarbiter I verify the most changes of this PR. We have successful test now for py3.10 now.
Just to clarify that _hintsvm.c is generated by the code. Could we add it to the .gitignore? Thanks.

@ariapoy ariapoy self-requested a review March 23, 2025 09:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ariapoy ariapoy Awaiting requested review from ariapoy

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@CoolJosh0221 @ariapoy