forked from MarquezProject/marquez
-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implementing metrics and user logs to Nu Data Lineage #23
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implementing metrics and user logs to Nu Data Lineage
This pull request introduces several new dependencies and enhancements to the project, focusing on logging, monitoring, and user information handling. The key changes include adding
prom-client
for metrics collection, integratingloglevel
for improved logging, and implementing a new API endpoint to log user information.Dependency Additions:
prom-client
dependency for metrics collection (package.json
,web/package.json
). [1] [2]loglevel
and its type definitions for enhanced logging capabilities (web/package-lock.json
,web/package.json
). [1] [2] [3] [4] [5] [6]Monitoring Enhancements:
prom-client
inweb/setupProxy.js
to collect default metrics and expose them via a/metrics
endpoint. [1] [2]Logging Enhancements:
web/setupProxy.js
)./api/loguserinfo
to log user information in a structured format (web/setupProxy.js
).LoginCallback
component to send user information to the new logging endpoint upon successful authentication (web/src/components/LoginCallback.tsx
).Checklist