Support mocking binary files, upgrade dependencies #7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The declared schema was wrong. This was detected during malli upgrade.
Use java.util.Base64 instead.
Don't try to convert the stored byte array into a String. Just base64-encode the byte array directly. This enables support to mock binary files correctly.
Type hint bindings in clj-github-mock.impl.jgit to avoid reflective access when interoping with JGit classes.
marcobiscaro2112
force-pushed
the
upgrade-deps
branch
from
da3f2e3 to
e01202a
Compare
marcobiscaro2112
force-pushed
the
upgrade-deps
branch
from
e01202a to
051bc6d
Compare
scottbale
approved these changes
Dec 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Review per commit is recommended.