Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

subset refactor #1967

Merged
merged 13 commits into from
May 20, 2024
Merged

subset refactor #1967

merged 13 commits into from
May 20, 2024

Conversation

alishakawaguchi
Copy link
Contributor

No description provided.

Copy link

linear bot commented May 20, 2024

Copy link

vercel bot commented May 20, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
neosync-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 20, 2024 5:36pm
neosync-marketing ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 20, 2024 5:36pm

Copy link

codecov bot commented May 20, 2024

Codecov Report

Attention: Patch coverage is 71.73252% with 93 lines in your changes are missing coverage. Please review.

Project coverage is 18.04%. Comparing base (cde7203) to head (74aca57).
Report is 10 commits behind head on main.

Current head 74aca57 differs from pull request most recent head db1162b

Please upload reports for the commit db1162b to get more accurate results.

Files Patch % Lines
...nc/activities/gen-benthos-configs/query-builder.go 87.26% 18 Missing and 16 partials ⚠️
backend/pkg/sqlmanager/postgres-manager.go 0.00% 29 Missing ⚠️
backend/pkg/sqlmanager/mysql-manager.go 0.00% 27 Missing ⚠️
.../activities/gen-benthos-configs/benthos-builder.go 60.00% 1 Missing and 1 partial ⚠️
backend/internal/loki/types.go 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1967      +/-   ##
==========================================
+ Coverage   17.99%   18.04%   +0.05%     
==========================================
  Files         212      212              
  Lines       46276    46412     +136     
==========================================
+ Hits         8328     8377      +49     
- Misses      36932    37004      +72     
- Partials     1016     1031      +15     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@alishakawaguchi alishakawaguchi merged commit ee79e50 into main May 20, 2024
8 checks passed
@alishakawaguchi alishakawaguchi deleted the alisha/neos-1089-subset-bug branch May 20, 2024 17:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant