Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NEOS-1266: exposes dynamodb as input output to neosync job #2348

Merged

Conversation

nickzelei
Copy link
Member

No description provided.

Copy link

linear bot commented Jul 24, 2024

Copy link

vercel bot commented Jul 24, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
neosync-docs ⬜️ Ignored (Inspect) Visit Preview Jul 29, 2024 8:57pm

@nickzelei nickzelei changed the title Nick/neos 1266 expose dynamodb as inputout to neosync job NEOS-1266: expose dynamodb as inputout to neosync job Jul 24, 2024
@nickzelei nickzelei added the enhancement New feature or request label Jul 24, 2024
@nickzelei nickzelei changed the title NEOS-1266: expose dynamodb as inputout to neosync job NEOS-1266: exposes dynamodb as input output to neosync job Jul 24, 2024
Copy link

codecov bot commented Jul 24, 2024

Codecov Report

Attention: Patch coverage is 1.25786% with 628 lines in your changes missing coverage. Please review.

Project coverage is 19.11%. Comparing base (9619c44) to head (cd21905).
Report is 7 commits behind head on main.

Files Patch % Lines
...end/gen/go/protos/mgmt/v1alpha1/job.pb.validate.go 0.00% 192 Missing ⚠️
...rotos/mgmt/v1alpha1/connection_data.pb.validate.go 0.00% 186 Missing ⚠️
...nc/activities/gen-benthos-configs/sync-dynamodb.go 0.00% 72 Missing ⚠️
backend/sql/postgresql/models/models.go 0.00% 48 Missing and 2 partials ⚠️
...1alpha1/connection-data-service/connection-data.go 0.00% 45 Missing ⚠️
.../activities/gen-benthos-configs/benthos-builder.go 0.00% 32 Missing ⚠️
backend/services/mgmt/v1alpha1/job-service/jobs.go 18.18% 22 Missing and 5 partials ⚠️
...ha1/mgmtv1alpha1connect/connection_data.connect.go 0.00% 18 Missing ⚠️
...pkg/workflows/datasync/activities/shared/shared.go 0.00% 3 Missing ⚠️
...async/activities/gen-benthos-configs/sync-mongo.go 0.00% 1 Missing ⚠️
... and 2 more
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2348      +/-   ##
==========================================
- Coverage   19.38%   19.11%   -0.28%     
==========================================
  Files         278      279       +1     
  Lines       54128    54949     +821     
==========================================
+ Hits        10494    10504      +10     
- Misses      42292    43097     +805     
- Partials     1342     1348       +6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@nickzelei nickzelei marked this pull request as ready for review July 29, 2024 20:57
@nickzelei nickzelei merged commit 622eb6f into main Jul 29, 2024
17 checks passed
@nickzelei nickzelei deleted the nick/neos-1266-expose-dynamodb-as-inputout-to-neosync-job branch July 29, 2024 21:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant