Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update workflow integration tests to use API and run in parallel #2896

Merged
merged 33 commits into from
Jan 2, 2025

Conversation

alishakawaguchi
Copy link
Contributor

No description provided.

@alishakawaguchi alishakawaguchi self-assigned this Nov 1, 2024
Copy link

vercel bot commented Nov 1, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
neosync-docs ⬜️ Ignored (Inspect) Visit Preview Jan 2, 2025 9:29pm

Copy link

codecov bot commented Nov 1, 2024

Codecov Report

Attention: Patch coverage is 0% with 194 lines in your changes missing coverage. Please review.

Please upload report for BASE (develop/v0.5@608c5e0). Learn more about missing BASE report.

Files with missing lines Patch % Lines
...nternal/testutil/testcontainers/mongodb/mongodb.go 0.00% 85 Missing ⚠️
...nal/testutil/testcontainers/sqlserver/sqlserver.go 0.00% 42 Missing ⚠️
...kend/pkg/integration-test/integration-test-util.go 0.00% 38 Missing ⚠️
internal/testutil/testcontainers/mysql/mysql.go 0.00% 15 Missing ⚠️
...ernal/testutil/testcontainers/postgres/postgres.go 0.00% 12 Missing ⚠️
worker/pkg/integration-test/datasync-workflow.go 0.00% 2 Missing ⚠️
Additional details and impacted files
@@               Coverage Diff               @@
##             develop/v0.5    #2896   +/-   ##
===============================================
  Coverage                ?   31.83%           
===============================================
  Files                   ?      357           
  Lines                   ?    41482           
  Branches                ?        0           
===============================================
  Hits                    ?    13204           
  Misses                  ?    26733           
  Partials                ?     1545           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

github-actions bot commented Dec 24, 2024

The latest Buf updates on your PR. Results from workflow Buf / buf (pull_request).

BuildFormatLintBreakingUpdated (UTC)
✅ passed✅ passed✅ passed❌ failed (36)Dec 26, 2024, 9:18 PM

@alishakawaguchi alishakawaguchi changed the base branch from main to develop/v0.5 December 26, 2024 21:22
@alishakawaguchi alishakawaguchi added the Devex Created by Linear-GitHub Sync label Dec 26, 2024
@alishakawaguchi alishakawaguchi changed the title WIP workflow integration tests refactor Update workflow integration tests to use test API and run in parallel Dec 26, 2024
@alishakawaguchi alishakawaguchi changed the title Update workflow integration tests to use test API and run in parallel Update workflow integration tests to use API and run in parallel Dec 26, 2024
@alishakawaguchi
Copy link
Contributor Author

I can't figure out why the linter is complaining about unused functions when they are all used

@alishakawaguchi alishakawaguchi marked this pull request as ready for review December 26, 2024 21:50
@nickzelei
Copy link
Member

I can't figure out why the linter is complaining about unused functions when they are all used

it's probably because they live in files that are not _test.go but -test.go and they are only being used from within _test.go files.

That's my hunch anyways. The linter is set to ignore lint errors in _test files (maybe this is a bad move on our part). So it is seeing those functions as being unused.

@nickzelei
Copy link
Member

nice
image

@alishakawaguchi alishakawaguchi merged commit 15758af into develop/v0.5 Jan 2, 2025
9 checks passed
@alishakawaguchi alishakawaguchi deleted the alisha/workflow-int-tests branch January 2, 2025 21:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Devex Created by Linear-GitHub Sync
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants