Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NEOS-1683: Transformer Config form now properly appears on clone #3102

Merged
merged 2 commits into from
Jan 7, 2025
Merged

NEOS-1683: Transformer Config form now properly appears on clone #3102

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ae5ea90
fixes transformer cloner form not appearing
nickzelei Jan 7, 2025
2cbc1f2
Adds padding to transformer edit form buttons
nickzelei Jan 7, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
33 changes: 21 additions & 12 deletions frontend/apps/web/app/(mgmt)/[account]/new/transformer/page.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,7 @@ import {
import { CheckIcon } from '@radix-ui/react-icons';
import { useRouter, useSearchParams } from 'next/navigation';
import { usePostHog } from 'posthog-js/react';
import { ReactElement, useEffect, useState } from 'react';
import { ReactElement, useEffect, useMemo, useState } from 'react';
import { useForm } from 'react-hook-form';
import { toast } from 'sonner';
import {
Expand All @@ -69,9 +69,9 @@ export default function NewTransformer(): ReactElement {
);
const transformers = data?.transformers ?? [];

const transformerQueryParam = useSearchParams().get('transformer');
const sourceIdToCloneQueryParam = useSearchParams().get('transformer');
const transformerSource = getTransformerSource(
transformerQueryParam ?? TransformerSource.UNSPECIFIED.toString()
sourceIdToCloneQueryParam ?? TransformerSource.GENERATE_BOOL.toString()
);
const { mutateAsync: isTransformerNameAvailableAsync } = useMutation(
TransformersService.method.isTransformerNameAvailable
Expand Down Expand Up @@ -152,24 +152,33 @@ export default function NewTransformer(): ReactElement {

const formSource = form.watch('source');

const base =
transformers.find((t) => t.source === formSource) ??
create(SystemTransformerSchema, {});

const configCase = form.watch('config.case');
const base = useMemo(
() =>
transformers.find((t) => t.source === formSource) ??
create(SystemTransformerSchema, {}),
[formSource, transformers]
);

useEffect(() => {
if (
isLoading ||
base.source === TransformerSource.UNSPECIFIED ||
configCase ||
!transformerQueryParam
!sourceIdToCloneQueryParam
) {
return;
}

form.setValue('config', convertTransformerConfigToForm(base.config));
}, [isLoading, base.source, configCase, transformerQueryParam]);
form.setValue('source', base.source, {
shouldDirty: true,
shouldTouch: true,
shouldValidate: false,
});
form.setValue('config', convertTransformerConfigToForm(base.config), {
shouldDirty: true,
shouldTouch: true,
shouldValidate: false,
});
}, [isLoading, sourceIdToCloneQueryParam]);

return (
<OverviewContainer
Expand Down
2 changes: 1 addition & 1 deletion ...tend/apps/web/app/(mgmt)/[account]/transformers/[id]/components/UpdateTransformerForm.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -188,7 +188,7 @@ export default function UpdateTransformerForm(props: Props): ReactElement {
)}
/>
</div>
<div className="flex flex-row justify-between">
<div className="flex flex-row justify-between py-4">
<NextLink href={`/${account?.name}/transformers?tab=ud`}>
<Button type="button">Back</Button>
</NextLink>
Expand Down
Loading