Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NEOS-1731: Fixes init types to properly handle python type hints #3196

Merged
merged 1 commit into from
Jan 27, 2025

Conversation

nickzelei
Copy link
Member

@nickzelei nickzelei commented Jan 27, 2025

I debugged this by installing neosync from pypi and noticing that the type hints werent really working.

I edited the module locally until vscode was able to properly find the type hints.

For whatever stupid reason both of these work, but only this diff fixes the type hints.

Tested with this script:

from neosync import Neosync, GetJobsRequest

client = Neosync(
    api_url="localhost:8080",
    insecure=True,
)
print(client)

jobs = client.jobs.GetJobs(
    GetJobsRequest(account_id="c79eca6c-a9f8-40f4-9ca8-b0b8eb0d1a21")
)
print(jobs)

@nickzelei nickzelei added the bug Something isn't working label Jan 27, 2025
@nickzelei nickzelei requested a review from evisdrenova January 27, 2025 22:00
Copy link

linear bot commented Jan 27, 2025

Copy link

vercel bot commented Jan 27, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
neosync-docs ⬜️ Ignored (Inspect) Jan 27, 2025 10:00pm

@nickzelei nickzelei merged commit 3417eab into main Jan 27, 2025
4 checks passed
@nickzelei nickzelei deleted the nick/neos-1731-fix-python-imports-types branch January 27, 2025 22:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants