Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make SecretKey::try_from_be_bytes() take just a slice reference #134

Merged
merged 3 commits into from
Jan 29, 2024

Conversation

fjarri
Copy link
Contributor

@fjarri fjarri commented Jan 28, 2024

Type of PR:

  • Feature

Required reviews:

  • 1

What this does:

  • Make SecretKey::try_from_be_bytes() take just a slice reference; it's the caller's responsibility to ensure that the storage is zeroized.
  • Bump MSRV to 1.70

This overrides #132.

Let the caller worry about wrapping it in a zeroized struct.
@codecov-commenter
Copy link

codecov-commenter commented Jan 28, 2024

Codecov Report

Attention: 7 lines in your changes are missing coverage. Please review.

Comparison is base (b3eaa7a) 58.11% compared to head (9a2ee66) 58.21%.

Files Patch % Lines
umbral-pre/src/keys.rs 0.00% 5 Missing ⚠️
umbral-pre/src/bindings_python.rs 0.00% 1 Missing ⚠️
umbral-pre/src/bindings_wasm.rs 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #134      +/-   ##
==========================================
+ Coverage   58.11%   58.21%   +0.09%     
==========================================
  Files          17       17              
  Lines        3123     3118       -5     
==========================================
  Hits         1815     1815              
+ Misses       1308     1303       -5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@fjarri fjarri merged commit 6f692dd into nucypher:master Jan 29, 2024
14 checks passed
@fjarri fjarri deleted the simplify-secrets branch January 29, 2024 04:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants