Merge branch 'hotfix/9.0.1' into develop

nuke-build · Nov 21, 2024 · 482f5ac · 482f5ac
2 parents 2d176b9 + 0398640
commit 482f5ac
Show file tree

Hide file tree

Showing 76 changed files with 164 additions and 550 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -6,6 +6,11 @@ and this project adheres to [Semantic Versioning](http://semver.org/spec/v2.0.0.
 
 ## [vNext]
 
+## [9.0.1] / 2024-11-21
+- Fixed `Options` serialization to JSON
+- Fixed `Options` for default members in interfaces
+- Fixed missing `ProcessExitHandler` setters
+
 ## [9.0.0] / 2024-11-21
 - Removed usages of `BinaryFormatter`
 - Changed minimum framework from `net6.0` to `net8.0`
@@ -1178,7 +1183,8 @@ and this project adheres to [Semantic Versioning](http://semver.org/spec/v2.0.0.
 - Added CLT tasks for Git
 - Fixed background color in console output
 
-[vNext]: https://github.com/nuke-build/nuke/compare/9.0.0...HEAD
+[vNext]: https://github.com/nuke-build/nuke/compare/9.0.1...HEAD
+[9.0.1]: https://github.com/nuke-build/nuke/compare/9.0.0...9.0.1
 [9.0.0]: https://github.com/nuke-build/nuke/compare/8.1.4...9.0.0
 [8.1.4]: https://github.com/nuke-build/nuke/compare/8.1.3...8.1.4
 [8.1.3]: https://github.com/nuke-build/nuke/compare/8.1.2...8.1.3

diff --git a/source/Nuke.Common/Tools/AzureSignTool/AzureSignTool.Generated.cs b/source/Nuke.Common/Tools/AzureSignTool/AzureSignTool.Generated.cs
@@ -43,7 +43,6 @@ public partial class AzureSignToolTasks : ToolTasks, IRequireNuGetPackage
 /// <summary>Used within <see cref="AzureSignToolTasks"/>.</summary>
 [PublicAPI]
 [ExcludeFromCodeCoverage]
-[TypeConverter(typeof(TypeConverter<AzureSignToolSettings>))]
 [Command(Type = typeof(AzureSignToolTasks), Command = nameof(AzureSignToolTasks.AzureSignTool), Arguments = "sign")]
 public partial class AzureSignToolSettings : ToolOptions
 {

diff --git a/source/Nuke.Common/Tools/BenchmarkDotNet/BenchmarkDotNet.Generated.cs b/source/Nuke.Common/Tools/BenchmarkDotNet/BenchmarkDotNet.Generated.cs
@@ -43,7 +43,6 @@ public partial class BenchmarkDotNetTasks : ToolTasks, IRequireNuGetPackage
 /// <summary>Used within <see cref="BenchmarkDotNetTasks"/>.</summary>
 [PublicAPI]
 [ExcludeFromCodeCoverage]
-[TypeConverter(typeof(TypeConverter<BenchmarkDotNetSettings>))]
 [Command(Type = typeof(BenchmarkDotNetTasks), Command = nameof(BenchmarkDotNetTasks.BenchmarkDotNet))]
 public partial class BenchmarkDotNetSettings : ToolOptions
 {

diff --git a/source/Nuke.Common/Tools/Boots/Boots.Generated.cs b/source/Nuke.Common/Tools/Boots/Boots.Generated.cs
@@ -43,7 +43,6 @@ public partial class BootsTasks : ToolTasks, IRequireNuGetPackage
 /// <summary>Used within <see cref="BootsTasks"/>.</summary>
 [PublicAPI]
 [ExcludeFromCodeCoverage]
-[TypeConverter(typeof(TypeConverter<BootsSettings>))]
 [Command(Type = typeof(BootsTasks), Command = nameof(BootsTasks.Boots))]
 public partial class BootsSettings : ToolOptions
 {

diff --git a/source/Nuke.Common/Tools/Chocolatey/Chocolatey.Generated.cs b/source/Nuke.Common/Tools/Chocolatey/Chocolatey.Generated.cs
@@ -96,7 +96,6 @@ public partial class ChocolateyTasks : ToolTasks, IRequirePathTool
 /// <summary>Used within <see cref="ChocolateyTasks"/>.</summary>
 [PublicAPI]
 [ExcludeFromCodeCoverage]
-[TypeConverter(typeof(TypeConverter<ChocolateySearchSettings>))]
 [Command(Type = typeof(ChocolateyTasks), Command = nameof(ChocolateyTasks.ChocolateySearch), Arguments = "search")]
 public partial class ChocolateySearchSettings : ToolOptions
 {
@@ -196,7 +195,6 @@ public partial class ChocolateySearchSettings : ToolOptions
 /// <summary>Used within <see cref="ChocolateyTasks"/>.</summary>
 [PublicAPI]
 [ExcludeFromCodeCoverage]
-[TypeConverter(typeof(TypeConverter<ChocolateyListSettings>))]
 [Command(Type = typeof(ChocolateyTasks), Command = nameof(ChocolateyTasks.ChocolateyList), Arguments = "list")]
 public partial class ChocolateyListSettings : ToolOptions
 {
@@ -296,7 +294,6 @@ public partial class ChocolateyListSettings : ToolOptions
 /// <summary>Used within <see cref="ChocolateyTasks"/>.</summary>
 [PublicAPI]
 [ExcludeFromCodeCoverage]
-[TypeConverter(typeof(TypeConverter<ChocolateyFindSettings>))]
 [Command(Type = typeof(ChocolateyTasks), Command = nameof(ChocolateyTasks.ChocolateyFind), Arguments = "find")]
 public partial class ChocolateyFindSettings : ToolOptions
 {
@@ -396,7 +393,6 @@ public partial class ChocolateyFindSettings : ToolOptions
 /// <summary>Used within <see cref="ChocolateyTasks"/>.</summary>
 [PublicAPI]
 [ExcludeFromCodeCoverage]
-[TypeConverter(typeof(TypeConverter<ChocolateyOutdatedSettings>))]
 [Command(Type = typeof(ChocolateyTasks), Command = nameof(ChocolateyTasks.ChocolateyOutdated), Arguments = "outdated")]
 public partial class ChocolateyOutdatedSettings : ToolOptions
 {
@@ -464,7 +460,6 @@ public partial class ChocolateyOutdatedSettings : ToolOptions
 /// <summary>Used within <see cref="ChocolateyTasks"/>.</summary>
 [PublicAPI]
 [ExcludeFromCodeCoverage]
-[TypeConverter(typeof(TypeConverter<ChocolateyPackSettings>))]
 [Command(Type = typeof(ChocolateyTasks), Command = nameof(ChocolateyTasks.ChocolateyPack), Arguments = "pack")]
 public partial class ChocolateyPackSettings : ToolOptions
 {
@@ -522,7 +517,6 @@ public partial class ChocolateyPackSettings : ToolOptions
 /// <summary>Used within <see cref="ChocolateyTasks"/>.</summary>
 [PublicAPI]
 [ExcludeFromCodeCoverage]
-[TypeConverter(typeof(TypeConverter<ChocolateyPushSettings>))]
 [Command(Type = typeof(ChocolateyTasks), Command = nameof(ChocolateyTasks.ChocolateyPush), Arguments = "push")]
 public partial class ChocolateyPushSettings : ToolOptions
 {
@@ -580,7 +574,6 @@ public partial class ChocolateyPushSettings : ToolOptions
 /// <summary>Used within <see cref="ChocolateyTasks"/>.</summary>
 [PublicAPI]
 [ExcludeFromCodeCoverage]
-[TypeConverter(typeof(TypeConverter<ChocolateyNewSettings>))]
 [Command(Type = typeof(ChocolateyTasks), Command = nameof(ChocolateyTasks.ChocolateyNew), Arguments = "new")]
 public partial class ChocolateyNewSettings : ToolOptions
 {

diff --git a/source/Nuke.Common/Tools/CodeMetrics/CodeMetrics.Generated.cs b/source/Nuke.Common/Tools/CodeMetrics/CodeMetrics.Generated.cs
@@ -43,7 +43,6 @@ public partial class CodeMetricsTasks : ToolTasks, IRequireNuGetPackage
 /// <summary>Used within <see cref="CodeMetricsTasks"/>.</summary>
 [PublicAPI]
 [ExcludeFromCodeCoverage]
-[TypeConverter(typeof(TypeConverter<CodeMetricsSettings>))]
 [Command(Type = typeof(CodeMetricsTasks), Command = nameof(CodeMetricsTasks.CodeMetrics))]
 public partial class CodeMetricsSettings : ToolOptions
 {

diff --git a/source/Nuke.Common/Tools/Codecov/Codecov.Generated.cs b/source/Nuke.Common/Tools/Codecov/Codecov.Generated.cs
@@ -42,7 +42,6 @@ public partial class CodecovTasks : ToolTasks, IRequireNuGetPackage
 /// <summary>Used within <see cref="CodecovTasks"/>.</summary>
 [PublicAPI]
 [ExcludeFromCodeCoverage]
-[TypeConverter(typeof(TypeConverter<CodecovSettings>))]
 [Command(Type = typeof(CodecovTasks), Command = nameof(CodecovTasks.Codecov))]
 public partial class CodecovSettings : ToolOptions
 {

diff --git a/source/Nuke.Common/Tools/CorFlags/CorFlags.Generated.cs b/source/Nuke.Common/Tools/CorFlags/CorFlags.Generated.cs
@@ -42,7 +42,6 @@ public partial class CorFlagsTasks : ToolTasks, IRequirePathTool
 /// <summary>Used within <see cref="CorFlagsTasks"/>.</summary>
 [PublicAPI]
 [ExcludeFromCodeCoverage]
-[TypeConverter(typeof(TypeConverter<CorFlagsSettings>))]
 [Command(Type = typeof(CorFlagsTasks), Command = nameof(CorFlagsTasks.CorFlags))]
 public partial class CorFlagsSettings : ToolOptions
 {

diff --git a/source/Nuke.Common/Tools/CoverallsNet/CoverallsNet.Generated.cs b/source/Nuke.Common/Tools/CoverallsNet/CoverallsNet.Generated.cs
@@ -43,7 +43,6 @@ public partial class CoverallsNetTasks : ToolTasks, IRequireNuGetPackage
 /// <summary>Used within <see cref="CoverallsNetTasks"/>.</summary>
 [PublicAPI]
 [ExcludeFromCodeCoverage]
-[TypeConverter(typeof(TypeConverter<CoverallsNetSettings>))]
 [Command(Type = typeof(CoverallsNetTasks), Command = nameof(CoverallsNetTasks.CoverallsNet))]
 public partial class CoverallsNetSettings : ToolOptions
 {

diff --git a/source/Nuke.Common/Tools/Coverlet/Coverlet.Generated.cs b/source/Nuke.Common/Tools/Coverlet/Coverlet.Generated.cs
@@ -44,7 +44,6 @@ public partial class CoverletTasks : ToolTasks, IRequireNuGetPackage
 /// <summary>Used within <see cref="CoverletTasks"/>.</summary>
 [PublicAPI]
 [ExcludeFromCodeCoverage]
-[TypeConverter(typeof(TypeConverter<CoverletSettings>))]
 [Command(Type = typeof(CoverletTasks), Command = nameof(CoverletTasks.Coverlet))]
 public partial class CoverletSettings : ToolOptions
 {

diff --git a/source/Nuke.Common/Tools/Discord/Discord.Generated.cs b/source/Nuke.Common/Tools/Discord/Discord.Generated.cs
@@ -21,7 +21,6 @@ namespace Nuke.Common.Tools.Discord;
 /// <summary>Used within <see cref="DiscordTasks"/>.</summary>
 [PublicAPI]
 [ExcludeFromCodeCoverage]
-[TypeConverter(typeof(TypeConverter<DiscordMessage>))]
 public partial class DiscordMessage : Options
 {
     /// <summary>Id of the channel.</summary>
@@ -40,7 +39,6 @@ public partial class DiscordMessage : Options
 /// <summary>Used within <see cref="DiscordTasks"/>.</summary>
 [PublicAPI]
 [ExcludeFromCodeCoverage]
-[TypeConverter(typeof(TypeConverter<DiscordEmbed>))]
 public partial class DiscordEmbed : Options
 {
     /// <summary>Title of embed.</summary>
@@ -71,7 +69,6 @@ public partial class DiscordEmbed : Options
 /// <summary>Used within <see cref="DiscordTasks"/>.</summary>
 [PublicAPI]
 [ExcludeFromCodeCoverage]
-[TypeConverter(typeof(TypeConverter<DiscordEmbedFooter>))]
 public partial class DiscordEmbedFooter : Options
 {
     /// <summary>Footer text.</summary>
@@ -84,7 +81,6 @@ public partial class DiscordEmbedFooter : Options
 /// <summary>Used within <see cref="DiscordTasks"/>.</summary>
 [PublicAPI]
 [ExcludeFromCodeCoverage]
-[TypeConverter(typeof(TypeConverter<DiscordEmbedImage>))]
 public partial class DiscordEmbedImage : Options
 {
     /// <summary>Source url of image (only supports http(s) and attachments).</summary>
@@ -99,7 +95,6 @@ public partial class DiscordEmbedImage : Options
 /// <summary>Used within <see cref="DiscordTasks"/>.</summary>
 [PublicAPI]
 [ExcludeFromCodeCoverage]
-[TypeConverter(typeof(TypeConverter<DiscordEmbedThumbnail>))]
 public partial class DiscordEmbedThumbnail : Options
 {
     /// <summary>Source url of thumbnail (only supports http(s) and attachments).</summary>
@@ -114,7 +109,6 @@ public partial class DiscordEmbedThumbnail : Options
 /// <summary>Used within <see cref="DiscordTasks"/>.</summary>
 [PublicAPI]
 [ExcludeFromCodeCoverage]
-[TypeConverter(typeof(TypeConverter<DiscordEmbedAuthor>))]
 public partial class DiscordEmbedAuthor : Options
 {
     /// <summary>Name of author.</summary>
@@ -129,7 +123,6 @@ public partial class DiscordEmbedAuthor : Options
 /// <summary>Used within <see cref="DiscordTasks"/>.</summary>
 [PublicAPI]
 [ExcludeFromCodeCoverage]
-[TypeConverter(typeof(TypeConverter<DiscordEmbedField>))]
 public partial class DiscordEmbedField : Options
 {
     /// <summary>Name of the field.</summary>

diff --git a/source/Nuke.Common/Tools/DocFX/DocFX.Generated.cs b/source/Nuke.Common/Tools/DocFX/DocFX.Generated.cs
@@ -124,7 +124,6 @@ public partial class DocFXTasks : ToolTasks, IRequireNuGetPackage
 /// <summary>Used within <see cref="DocFXTasks"/>.</summary>
 [PublicAPI]
 [ExcludeFromCodeCoverage]
-[TypeConverter(typeof(TypeConverter<DocFXBuildSettings>))]
 [Command(Type = typeof(DocFXTasks), Command = nameof(DocFXTasks.DocFXBuild), Arguments = "build")]
 public partial class DocFXBuildSettings : ToolOptions
 {
@@ -222,7 +221,6 @@ public partial class DocFXBuildSettings : ToolOptions
 /// <summary>Used within <see cref="DocFXTasks"/>.</summary>
 [PublicAPI]
 [ExcludeFromCodeCoverage]
-[TypeConverter(typeof(TypeConverter<DocFXDependencySettings>))]
 [Command(Type = typeof(DocFXTasks), Command = nameof(DocFXTasks.DocFXDependency), Arguments = "dependency")]
 public partial class DocFXDependencySettings : ToolOptions
 {
@@ -240,7 +238,6 @@ public partial class DocFXDependencySettings : ToolOptions
 /// <summary>Used within <see cref="DocFXTasks"/>.</summary>
 [PublicAPI]
 [ExcludeFromCodeCoverage]
-[TypeConverter(typeof(TypeConverter<DocFXDownloadSettings>))]
 [Command(Type = typeof(DocFXTasks), Command = nameof(DocFXTasks.DocFXDownload), Arguments = "download")]
 public partial class DocFXDownloadSettings : ToolOptions
 {
@@ -256,7 +253,6 @@ public partial class DocFXDownloadSettings : ToolOptions
 /// <summary>Used within <see cref="DocFXTasks"/>.</summary>
 [PublicAPI]
 [ExcludeFromCodeCoverage]
-[TypeConverter(typeof(TypeConverter<DocFXHelpSettings>))]
 [Command(Type = typeof(DocFXTasks), Command = nameof(DocFXTasks.DocFXHelp), Arguments = "help")]
 public partial class DocFXHelpSettings : ToolOptions
 {
@@ -268,7 +264,6 @@ public partial class DocFXHelpSettings : ToolOptions
 /// <summary>Used within <see cref="DocFXTasks"/>.</summary>
 [PublicAPI]
 [ExcludeFromCodeCoverage]
-[TypeConverter(typeof(TypeConverter<DocFXInitSettings>))]
 [Command(Type = typeof(DocFXTasks), Command = nameof(DocFXTasks.DocFXInit), Arguments = "init")]
 public partial class DocFXInitSettings : ToolOptions
 {
@@ -292,7 +287,6 @@ public partial class DocFXInitSettings : ToolOptions
 /// <summary>Used within <see cref="DocFXTasks"/>.</summary>
 [PublicAPI]
 [ExcludeFromCodeCoverage]
-[TypeConverter(typeof(TypeConverter<DocFXMergeSettings>))]
 [Command(Type = typeof(DocFXTasks), Command = nameof(DocFXTasks.DocFXMerge), Arguments = "merge")]
 public partial class DocFXMergeSettings : ToolOptions
 {
@@ -326,7 +320,6 @@ public partial class DocFXMergeSettings : ToolOptions
 /// <summary>Used within <see cref="DocFXTasks"/>.</summary>
 [PublicAPI]
 [ExcludeFromCodeCoverage]
-[TypeConverter(typeof(TypeConverter<DocFXMetadataSettings>))]
 [Command(Type = typeof(DocFXTasks), Command = nameof(DocFXTasks.DocFXMetadata), Arguments = "metadata")]
 public partial class DocFXMetadataSettings : ToolOptions
 {
@@ -368,7 +361,6 @@ public partial class DocFXMetadataSettings : ToolOptions
 /// <summary>Used within <see cref="DocFXTasks"/>.</summary>
 [PublicAPI]
 [ExcludeFromCodeCoverage]
-[TypeConverter(typeof(TypeConverter<DocFXPdfSettings>))]
 [Command(Type = typeof(DocFXTasks), Command = nameof(DocFXTasks.DocFXPdf), Arguments = "pdf")]
 public partial class DocFXPdfSettings : ToolOptions
 {
@@ -490,7 +482,6 @@ public partial class DocFXPdfSettings : ToolOptions
 /// <summary>Used within <see cref="DocFXTasks"/>.</summary>
 [PublicAPI]
 [ExcludeFromCodeCoverage]
-[TypeConverter(typeof(TypeConverter<DocFXServeSettings>))]
 [Command(Type = typeof(DocFXTasks), Command = nameof(DocFXTasks.DocFXServe), Arguments = "serve")]
 public partial class DocFXServeSettings : ToolOptions
 {
@@ -508,7 +499,6 @@ public partial class DocFXServeSettings : ToolOptions
 /// <summary>Used within <see cref="DocFXTasks"/>.</summary>
 [PublicAPI]
 [ExcludeFromCodeCoverage]
-[TypeConverter(typeof(TypeConverter<DocFXTemplateSettings>))]
 [Command(Type = typeof(DocFXTasks), Command = nameof(DocFXTasks.DocFXTemplate), Arguments = "template")]
 public partial class DocFXTemplateSettings : ToolOptions
 {