Skip to content

Commit

Permalink
Fix rubocop issues
Browse files Browse the repository at this point in the history
  • Loading branch information
danielsilva committed Dec 4, 2023
1 parent 29b7ba1 commit 697f47d
Show file tree
Hide file tree
Showing 5 changed files with 11 additions and 3 deletions.
5 changes: 4 additions & 1 deletion .rubocop.yml
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ AllCops:
NewCops: enable
TargetRubyVersion: 2.7

Gemspec/DateAssignment:
Gemspec/DeprecatedAttributeAssignment:
Enabled: true

Layout/EmptyLinesAroundAttributeAccessor:
Expand Down Expand Up @@ -135,6 +135,9 @@ RSpec/MessageSpies:
RSpec/NotToNot:
EnforcedStyle: to_not

RSpec/Rails/InferredSpecType:
Enabled: false

Style/AccessorGrouping:
Enabled: true

Expand Down
3 changes: 2 additions & 1 deletion nulogy_graphql_api.gemspec
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,8 @@ Gem::Specification.new do |spec|
"homepage_uri" => "https://github.com/nulogy/nulogy_graphql_api",
"changelog_uri" => "https://github.com/nulogy/nulogy_graphql_api/blob/master/CHANGELOG.md",
"source_code_uri" => "https://github.com/nulogy/nulogy_graphql_api",
"bug_tracker_uri" => "https://github.com/nulogy/nulogy_graphql_api/issues"
"bug_tracker_uri" => "https://github.com/nulogy/nulogy_graphql_api/issues",
"rubygems_mfa_required" => "true"
}

spec.required_ruby_version = Gem::Requirement.new(">= 2.6.0")
Expand Down
2 changes: 1 addition & 1 deletion spec/integration_spec_helper.rb
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@
require "rspec/rails"
require "active_record"
require "nulogy_graphql_api/rspec"
require_relative "./helpers/db_helpers"
require_relative "helpers/db_helpers"

RSpec.configure do |config|
# Uncomment this line to see full backtraces for spec failures
Expand Down
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
# rubocop:disable RSpec/FilePath
# rubocop:disable RSpec/SpecFilePathFormat
RSpec.describe DummyApiController, :graphql, type: :request do
it "returns graphql response" do
query = <<~GRAPHQL
Expand Down Expand Up @@ -87,3 +88,4 @@ def consider_all_requests_non_local
end
end
# rubocop:enable RSpec/FilePath
# rubocop:enable RSpec/SpecFilePathFormat
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
# rubocop:disable RSpec/FilePath
# rubocop:disable RSpec/SpecFilePathFormat
RSpec.describe DummyBaseController, type: :request do
it "returns Not Found when requesting an entity that does not exist" do
get "/graphql_api/dummy_base/test_record_not_found"
Expand Down Expand Up @@ -65,3 +66,4 @@ def consider_all_requests_non_local
end
end
# rubocop:enable RSpec/FilePath
# rubocop:enable RSpec/SpecFilePathFormat

0 comments on commit 697f47d

Please sign in to comment.