-
Notifications
You must be signed in to change notification settings - Fork 21
chore: bump python version #221
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Signed-off-by: Shrivardhan Rao <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #221 +/- ##
=======================================
Coverage 94.20% 94.20%
=======================================
Files 55 55
Lines 2311 2311
Branches 119 119
=======================================
Hits 2177 2177
Misses 97 97
Partials 37 37 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
pyproject.toml
Outdated
@@ -21,7 +21,7 @@ classifiers = [ | |||
repository = "https://github.com/numaproj/numaflow-python" | |||
|
|||
[tool.poetry.dependencies] | |||
python = ">=3.9, <3.13" | |||
python = ">=3.9, <4.0" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Make it < 3.14.
Things might break otherwise in future
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1 Python changes a lot between the minor versions :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
TBH, it is very difficult to support 5 versions of Python simultaneously and have trouble free builds. I would vote for dropping support for 3.9 if we are adding 3.13.
Anyway 3.9 is going obsolete after Oct 2025.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1 yank support for 3.9
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Make it < 3.14.
Things might break otherwise in future
I'm against limiting the version of Python.
Please read the following: https://iscinumpy.dev/post/bound-version-constraints/
If you still think there's a good reason to block 3.14+, please share it.
Note that supported versions will still be listed in classifiers... so if somebody uses a version not listed, then they use at their own risk.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm ambivalent about dropping support for Python 3.9, so I'll refrain from giving an opinion on that.
Signed-off-by: Shrivardhan Rao <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please make sure a minor version is released for this (when you release it).
@@ -21,7 +21,7 @@ classifiers = [ | |||
repository = "https://github.com/numaproj/numaflow-python" | |||
|
|||
[tool.poetry.dependencies] | |||
python = ">=3.9, <3.13" | |||
python = ">=3.9,<3.14" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add "Programming Language :: Python :: 3.13"
in the classifiers
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You also need to add tests to make sure python 3.13 pass
https://github.com/numaproj/numaflow-python/blob/main/.github/workflows/run-tests.yml
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Per my other comment, please consider changing to:
python = ">=3.9,<3.14" | |
python = "^3.9" |
Or if none of this packages dependencies cap the Python version (unlikely), then this would be better:
python = ">=3.9,<3.14" | |
python = ">=3.9" |
Signed-off-by: Shrivardhan Rao <[email protected]>
|
This is tricky, let's a CI rule for that in a follow up. I do not want to block this PR because of that. |
Signed-off-by: Shrivardhan Rao <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please consider removing the Python minor version cap, maybe in the next PR.
Is this PR still moving forward? I don't see any updates more than a month, and Python 3.13 went GA more than 6 months ago.
pyproject.toml
Outdated
@@ -21,7 +21,7 @@ classifiers = [ | |||
repository = "https://github.com/numaproj/numaflow-python" | |||
|
|||
[tool.poetry.dependencies] | |||
python = ">=3.9, <3.13" | |||
python = ">=3.9, <4.0" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Make it < 3.14.
Things might break otherwise in future
I'm against limiting the version of Python.
Please read the following: https://iscinumpy.dev/post/bound-version-constraints/
If you still think there's a good reason to block 3.14+, please share it.
Note that supported versions will still be listed in classifiers... so if somebody uses a version not listed, then they use at their own risk.
pyproject.toml
Outdated
@@ -21,7 +21,7 @@ classifiers = [ | |||
repository = "https://github.com/numaproj/numaflow-python" | |||
|
|||
[tool.poetry.dependencies] | |||
python = ">=3.9, <3.13" | |||
python = ">=3.9, <4.0" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm ambivalent about dropping support for Python 3.9, so I'll refrain from giving an opinion on that.
@@ -21,7 +21,7 @@ classifiers = [ | |||
repository = "https://github.com/numaproj/numaflow-python" | |||
|
|||
[tool.poetry.dependencies] | |||
python = ">=3.9, <3.13" | |||
python = ">=3.9,<3.14" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Per my other comment, please consider changing to:
python = ">=3.9,<3.14" | |
python = "^3.9" |
Or if none of this packages dependencies cap the Python version (unlikely), then this would be better:
python = ">=3.9,<3.14" | |
python = ">=3.9" |
update allowed python version