NUP-2506: Add test to all Serializable subclasses and fix related issues #3826
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rhyolight
reviewed
Apr 10, 2018
| return anomalyRegion | ||
|
|
||
|
|
||
| def write(self, proto): | ||
| proto.prevPredictedColumns = self.prevPredictedColumns.tolist() | ||
| proto.prevPredictedColumns = self.prevPredictedColumns.ravel().tolist() |
rhyolight
approved these changes
Apr 10, 2018
| if self.currentOutput is not None: | ||
| proto.currentOutput = self.currentOutput.tolist() | ||
| if self.currentOutput is None: | ||
| proto.currentOutput.none = None |
There was a problem hiding this comment.
I don't understand this. Is it a workaround to allow a proto to contain a null value? I see this pattern in several other places.
There was a problem hiding this comment.
This is a way to handle 'None' in pycapnp. You first create a union with a 'Void' element representing 'None' and then initialize it with 'None'
see https://jparyani.github.io/pycapnp/quickstart.html#unions
| @@ -126,7 +126,7 @@ def __init__(self, | |||
| # If set to False, Cells4 will *not* be treated as an ephemeral member | |||
| # and full BacktrackingTMCPP pickling is possible. This is useful for testing | |||
| # pickle/unpickle without saving Cells4 to an external file | |||
| self.makeCells4Ephemeral = True | |||
| self.makeCells4Ephemeral = False | |||
| actual = _getAttributes(serialized) | ||
|
|
||
| # Make sure all fields were initialized | ||
| self.assertEquals(actual, expected, klass.__name__) |
| encoder._prevAbsolute = proto.prevAbsolute | ||
| encoder._prevDelta = proto.prevDelta | ||
| encoder._prevAbsolute = None if proto.prevAbsolute == 0 else proto.prevAbsolute | ||
| encoder._prevDelta = None if proto.prevDelta == 0 else proto.prevDelta |
There was a problem hiding this comment.
I personally don't think this is a bad change, but I'm curious if it will pass pylint.
There was a problem hiding this comment.
pylint did not complain about this style
|
👍 Merge it and I'll release. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@rhyolight Please review.
It should fix #3820, #3721, numenta/nupic.core-legacy#1065